Skip to content

[No QA] Update Add-Expensify-Card-to-Apple-Pay-or-Google-Wallet.md - #102912

Merged
stephanieelliott merged 3 commits into
mainfrom
brianlee-expensify-patch-4
Oct 20, 2026
Merged

stephanieelliott merged 3 commits into
mainfrom
brianlee-expensify-patch-4

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

Explanation of Change

  • made distinction about UK/EU based cardholders not having Apple Pay or Google Wallet support just yet.

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

# Add the Expensify Card to Apple Pay or Google Wallet

You can use your Expensify Card for contactless in-person payments by adding it to Apple Pay or Google Wallet.
You can use your Expensify Card (currently available for US cardholders only) for contactless in-person payments by adding it to Apple Pay or Google Wallet. Support for UK/EU cardholders will be available towards the end of 2026.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vague wording / non-deterministic writing: "towards the end of 2026" is imprecise and creates maintenance debt. Per HELP_AUTHORING_GUIDELINES.md Section 6 ("Avoid vague wording") and the Deterministic Writing Rule in HELPSITE_NAMING_CONVENTIONS.md (be literal, be exact), avoid soft future-dated promises. Prefer stating only the current limitation without a speculative timeframe, e.g. "currently available for US cardholders only; support for UK/EU cardholders is coming soon." If a date must be referenced, it should be specific and committed.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a single, focused one-line change to the intro paragraph of the article Add-Expensify-Card-to-Apple-Pay-or-Google-Wallet.md, adding regional availability context: the Expensify Card is currently available for US cardholders only, with UK/EU support expected toward the end of 2026. The change is a sensible, factual clarification that sets correct expectations for a global audience. Scores below reflect only the proposed diff, not the unchanged article.

Scores Summary

  • Readability: 8/10 - The added sentence is clear and the limitation is communicated up front. The parenthetical inside the first sentence makes it slightly long; splitting into a short follow-on sentence would read more cleanly.
  • AI Readiness: 8/10 - The added limitation uses the full feature name (Expensify Card) and is placed in the intro where the authoring guidelines recommend stating important limitations. No headings or metadata were touched, so retrieval structure is unaffected. Consider whether internalScope and keywords should mention regional availability so the limitation is discoverable.
  • Style Compliance: 7/10 - Content follows the convention of stating limitations explicitly rather than softening them. Minor nit: UK/EU uses a slash shorthand; spelling out 'UK and EU' is clearer and more consistent with the deterministic, non-abbreviated writing style the conventions favor.

Key Findings

  • Positive: The limitation is stated clearly and placed in the intro paragraph, exactly where TEMPLATE.md and the authoring guidelines direct important limitations to go.
  • Positive: No naming, heading, or structural conventions are violated; the full feature name is used.
  • Minor: The first sentence now carries two ideas (how to use the card and where it is available); splitting improves scannability.
  • Minor: The UK/EU slash abbreviation is slightly informal versus the deterministic writing rule.

Recommendations

  • Optional polish: Split the limitation into its own sentence, e.g. 'You can use your Expensify Card for contactless in-person payments by adding it to Apple Pay or Google Wallet. The Expensify Card is currently available to US cardholders only; support for UK and EU cardholders is expected toward the end of 2026.'
  • Consider adding the regional availability note to internalScope and/or keywords so AI retrieval surfaces it for availability-related queries.
  • No blocking issues. The change is accurate and merge-ready.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Add-Expensify-Card-to-Apple-Pay-or-Google-Wallet.md - One-line intro update adding regional availability. Compliant, with minor optional readability/style polish suggested.

Note: This is a single-line change, so no separate inline comments were necessary.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c38479b26

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions Bot changed the title Update Add-Expensify-Card-to-Apple-Pay-or-Google-Wallet.md [No QA] Update Add-Expensify-Card-to-Apple-Pay-or-Google-Wallet.md Oct 2, 2026
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@rafecolton rafecolton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better not to commit to a specific time period here. Suggested some other updates for brevity.

Co-authored-by: Rafe Colton <1058475+rafecolton@users.noreply.github.com>
@stephanieelliott
stephanieelliott requested a review from a team October 3, 2026 03:32
@melvin-bot

melvin-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @muttmuure

@melvin-bot
melvin-bot Bot requested a review from muttmuure October 3, 2026 03:32
@melvin-bot

melvin-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

@muttmuure Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 3, 2026 03:32
@OSBotify

OSBotify commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://7db8965d.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 7, 2026
@stephanieelliott
stephanieelliott merged commit f251428 into main Oct 20, 2026
17 of 19 checks passed
@stephanieelliott
stephanieelliott deleted the brianlee-expensify-patch-4 branch October 20, 2026 01:20
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants