Repository navigation
[No QA] Docs updates for E/A#101226 Let any admin pay with connected bank account - #102952
Conversation
Co-authored-by: Lorre Naga <lorretheboy@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://21380050.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| - **No bank account connected:** workspace admins can use **Mark as Paid** to record payments made outside of Expensify. | ||
| - **Bank account connected:** The authorized payer and workspace admins the bank account has been shared with can pay reports. | ||
| - **Bank account connected:** Any **Workspace admin** or **Payments admin** can pay reports from a bank account they have access to, or use **Mark as paid**. |
There was a problem hiding this comment.
UI label mismatch: The product UI label is Mark as Paid (capital P), as used elsewhere in this same article (lines 83 and 89). Change **Mark as paid** to **Mark as Paid** to match the exact UI label and stay consistent. Per HELPSITE_NAMING_CONVENTIONS.md, UI labels must match capitalization exactly.
|
|
||
| - **No bank account connected:** workspace admins can use **Mark as Paid** to record payments made outside of Expensify. | ||
| - **Bank account connected:** The authorized payer and workspace admins the bank account has been shared with can pay reports. | ||
| - **Bank account connected:** Any **Workspace admin** or **Payments admin** can pay reports from a bank account they have access to, or use **Mark as paid**. |
There was a problem hiding this comment.
Terminology/casing inconsistency: Role names are capitalized as Workspace Admin and Payments Admins elsewhere in this article (lines 23, 25, 54, 82). Use **Workspace admin** → **Workspace Admin** and **Payments admin** → **Payments Admin** for consistent role capitalization.
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.5-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Allow any workspace admin to pay reports lets any Workspace admin or Payments admin pay a report when a business bank account is connected, even if the bank account wasn't shared with them. They pay from a bank account they have access to, or use Mark as paid.
This sentence in Workspace Workflows is now incorrect:
It now reads:
Pay Expenses already describes the new behavior, so it needs no change.
Fixed Issues
$ #101226
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@lorretheboy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.