Skip to content

[No QA] Docs updates for E/A#101226 Let any admin pay with connected bank account - #102952

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsAnyAdminCanPayWithBankAccount
Oct 7, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsAnyAdminCanPayWithBankAccount

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Allow any workspace admin to pay reports lets any Workspace admin or Payments admin pay a report when a business bank account is connected, even if the bank account wasn't shared with them. They pay from a bank account they have access to, or use Mark as paid.

This sentence in Workspace Workflows is now incorrect:

Bank account connected: The authorized payer and workspace admins the bank account has been shared with can pay reports.

It now reads:

Bank account connected: Any Workspace admin or Payments admin can pay reports from a bank account they have access to, or use Mark as paid.

Pay Expenses already describes the new behavior, so it needs no change.

Fixed Issues

$ #101226
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@lorretheboy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Lorre Naga <lorretheboy@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 5, 2026
@MelvinBot
MelvinBot requested a review from a team October 5, 2026 00:26
@MelvinBot MelvinBot mentioned this pull request Oct 5, 2026
43 tasks done
@github-actions github-actions Bot changed the title Docs updates for E/A#101226 Let any admin pay with connected bank account [No QA] Docs updates for E/A#101226 Let any admin pay with connected bank account Oct 5, 2026
@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://21380050.helpdot.pages.dev ⚡️

Updated articles:

@melvin-bot

melvin-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @kadiealexander

@melvin-bot
melvin-bot Bot requested review from kadiealexander and removed request for a team October 7, 2026 03:53
@melvin-bot

melvin-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]


- **No bank account connected:** workspace admins can use **Mark as Paid** to record payments made outside of Expensify.
- **Bank account connected:** The authorized payer and workspace admins the bank account has been shared with can pay reports.
- **Bank account connected:** Any **Workspace admin** or **Payments admin** can pay reports from a bank account they have access to, or use **Mark as paid**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI label mismatch: The product UI label is Mark as Paid (capital P), as used elsewhere in this same article (lines 83 and 89). Change **Mark as paid** to **Mark as Paid** to match the exact UI label and stay consistent. Per HELPSITE_NAMING_CONVENTIONS.md, UI labels must match capitalization exactly.


- **No bank account connected:** workspace admins can use **Mark as Paid** to record payments made outside of Expensify.
- **Bank account connected:** The authorized payer and workspace admins the bank account has been shared with can pay reports.
- **Bank account connected:** Any **Workspace admin** or **Payments admin** can pay reports from a bank account they have access to, or use **Mark as paid**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology/casing inconsistency: Role names are capitalized as Workspace Admin and Payments Admins elsewhere in this article (lines 23, 25, 54, 82). Use **Workspace admin** → **Workspace Admin** and **Payments admin** → **Payments Admin** for consistent role capitalization.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a single, targeted correction to one bullet in Workspace-Workflows.md, updating who can pay reports when a business bank account is connected. The change accurately reflects the new product behavior (any Workspace admin or Payments admin can pay). The edit is small, factual, and reads clearly, but it introduces a couple of terminology-casing inconsistencies against the governance rules and the surrounding text.

Scores Summary

  • Readability: 9/10 - The revised sentence is clear, concise, and well structured. Bolding of roles and the payment action aids scannability.
  • AI Readiness: 8/10 - No metadata or heading changes in the diff, so nothing regresses. Full feature/action names are used. Scored against only the changed line, which is self-contained and retrievable.
  • Style Compliance: 6/10 - Two casing inconsistencies: the action is written as Mark as paid while the adjacent (unchanged) bullet uses Mark as Paid; and roles are written Workspace admin / Payments admin (lowercase admin) rather than the capitalized role terminology used elsewhere in governance (e.g. Workspace Admin).

Key Findings

  • Positive: The change is an accurate, needed correction that matches the behavior already described in Pay Expenses, and the sentence is cleaner and easier to read than the version it replaces.
  • Style issue (button casing): Mark as paid should match the exact UI label. The same section (unchanged line) renders it as Mark as Paid. Per the Button Naming Standards, use the exact UI text and keep it consistent within the article.
  • Style issue (role casing): Workspace admin and Payments admin use lowercase admin. Confirm the canonical role casing (Workspace Admin) and apply it consistently so the roles read as defined terms.

Recommendations

  • Verify the exact product label for the pay action and align the new line with it (and with the adjacent bullet): either both Mark as Paid or both Mark as paid.
  • Align role capitalization with the governance terminology (e.g. Workspace Admin) and confirm Payments admin is the exact role name used in the product UI.
  • No structural, metadata, or cross-link changes are needed; scope of the edit is appropriate.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - One-line factual correction; accurate and readable, minor casing/terminology consistency fixes recommended.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 2e3db23 into main Oct 7, 2026
23 of 24 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsAnyAdminCanPayWithBankAccount branch October 7, 2026 04:12
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-07T04:24:39.462278Z c9f389d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@OSBotify OSBotify mentioned this pull request Oct 7, 2026
68 tasks done
@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.5-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants