Repository navigation
[Insights Polish] Chart area and labels - #102969
cristipaval merged 8 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot review |
ReviewI found no blocking issues. The layout math checks out, and all CI checks pass except the approval gate. What I verified
Suggestions (non-blocking):
|
|
I'll defer to @dannymcclain on this one - I think I would expect the last one to have a line? And I think I might expect the $0 line to be solid? No strong feels, just gut reactions |
I think this is actually pretty solid, but reading Shawn's comment:
I'd be down to see it this way—I removed the bottom/ So let's try Shawn's suggestion here:
Can we also add |
|
I think that looks pretty great. @shawnborton (and @dubielzyk-expensify) what do you think? |
|
Big fan personally, that feels much more expected. |
|
Cool, @mhawryluk we have a failing jest check. @truph01 can you prioritize this review please? |
Agree. That looks good to me 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-06.at.09.57.57.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-10-06.at.09.50.59.mov |
|
Code changes look good! @mhawryluk Could you resolve the failing check? |
resolved by merging main |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.5.4-0 🚀
|
|
No help site update is needed: this PR only changes chart styling (dashed gridlines, right-side y-axis labels, label color) and fixes x-axis label rotation, and no article under |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |









Explanation of Change
Updates the chart area styling for the line and vertical bar charts to match the new Insights designs:
ChartGridLinescomponent draws them behind the chart content.LeftFrameLinecomponent.Also included a bug fix:
Horizontal bar charts are intentionally left as they are, since they'll be removed in an upcoming PR. Their only change is passing canvasWidth to
ChartYAxisLabelsto match its new props.These changes also apply to Spend charts. They don't change data, interactions, or which labels are shown.
Fixed Issues
$ #102861
PROPOSAL: N/A
Tests
insightsPagebeta.Offline tests
N/A
QA Steps
insightsPagebeta disabled.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-10-05.at.11.48.09.mov
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-10-5.o.11.45.26.mov