Repository navigation
Bump lodash-es to 4.18.1 to address security advisories - #103009
Merged
Merged
Conversation
Contributor
|
I will check it soon |
Contributor
|
@Gonals Do we need a C+ review for this? |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
amyevans
approved these changes
Oct 6, 2026
Gonals
self-requested a review
October 6, 2026 12:29
Gonals
approved these changes
Oct 6, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
100 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.4-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |
53 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Bumps
lodash-es4.17.21→4.18.1to fix Dependabot alerts GHSA-r5fr-rjxr-66jc (_.templatecode injection), GHSA-f23m-r3pf-42rh, and GHSA-xxjr-mmjv-4gpg (_.unset/_.omitprototype pollution). This matcheslodash, which is already on4.18.1.How it's used: It is web-only. Rsbuild aliases
lodash→lodash-es(config/rsbuild/rsbuild.common.ts:179), so everylodash/*import in the web bundle resolves tolodash-es(isEmpty,debounce,cloneDeep,sortBy, etc.). Onlyomittouches a patched function, inNavigation.goUproute matching (src/libs/Navigation/Navigation.ts:360).template/unsetare unused. Native builds uselodashand are unaffected.Change Log
ReferenceErrorin modular builds fortemplateandfromPairs._.unset/_.omit:constructor/prototypeare now blocked as non-terminal path keys (GHSA-f23m-r3pf-42rh)._.template:importskeys with forbidden identifier chars now throw (GHSA-r5fr-rjxr-66jc, CVE-2026-4800)._.unset/_.omitprototype pollution fix (GHSA-xxjr-mmjv-4gpg).Releases · Full diff
AI tests: The sandbox could not run
npm install/npm ci, so lint, typecheck, and Jest were not run locally. CI must verify the change.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/688722
PROPOSAL:
Tests
Web only:
npm ci, thennpm run web, and sign in.Navigation.goUp→omit).Offline tests
N/A. This is a dependency bump with no network behavior change.
QA Steps
Same as tests, on web staging (skip step 1).
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari