Skip to content

[No QA] Fix Android release artifacts on Rock cache hits - #103079

Merged
puneetlath merged 2 commits into
mainfrom
fix/android-rock-cache-artifacts
Oct 6, 2026
Merged

puneetlath merged 2 commits into
mainfrom
fix/android-rock-cache-artifacts

Conversation

@puneetlath

@puneetlath puneetlath commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Collect the Android AAB from Rock's exact ARTIFACT_PATH when no Gradle output exists, then generate the APK from the collected AAB. A Release build now fails immediately when neither location contains an AAB instead of reporting success and leaving Google Play and BrowserStack without artifacts. Using Rock's recorded path avoids accidentally picking a different cached AAB.

The failing staging run produced a signed AAB at .rock/cache/remote-build/.../Expensify-release.aab; the workflow only searched Mobile-Expensify/Android. A fresh-build run produced the AAB under Mobile-Expensify/Android/build/outputs/bundle/release/ and succeeded.

Fixed Issues

N/A — no issue filed; failing deploy run.
PROPOSAL: N/A

Tests

N/A - this is a change to the GH action, not a product change

  • N/A — JS console: workflow-only change.

Offline tests

  1. Confirm no app runtime behavior changes; this build workflow requires network access to download Rock artifacts and publish release artifacts.

QA Steps

  1. Trigger a staging Android Release deploy with a Rock cache hit.
  2. Confirm the build job uploads androidBuild-artifact and android-apk-artifact.
  3. Confirm the Google Play and BrowserStack jobs download those artifacts successfully.
  • N/A — JS console: workflow-only change.

AI Tests

  • Passed: fresh-Release, cached-Release with a stale cached AAB, missing-Release, and missing-Adhoc artifact-collection fixtures, including collected AAB path selection for APK generation.
  • Passed: npx oxfmt --check .github/workflows/buildAndroid.yml, npm run lint-changed, npm run spell-changed, ./.github/scripts/verifyActions.sh, and git diff --check.
  • Not run locally: full native Android CI build; staging deploy validation is described above.

PR Author Checklist

  • N/A — issue link: no issue filed; failing run linked in ### Fixed Issues.
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • N/A — offline app testing: CI workflow; no app offline behavior.
    • N/A — High Traffic account testing: CI workflow; no account behavior.
  • N/A — platform screenshots or videos: CI workflow; no UI.
  • N/A — app runtime tests on all platforms: only the Android build workflow changed.
    • Android: Native (workflow fixtures passed; full staging build pending)
    • Android: mWeb Chrome (N/A: CI workflow)
    • iOS: Native (N/A: CI workflow)
    • iOS: mWeb Safari (N/A: CI workflow)
    • MacOS: Chrome / Safari (N/A: CI workflow)
  • N/A — JS console errors: CI workflow; no JS runtime changed.
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English (N/A: no app copy changed)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers (N/A: no new pattern)
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (N/A: only Android artifact consumers; covered in QA steps)
  • If a new CSS style is added I verified that a similar style doesn't already exist and that the style can't be created with an existing StyleUtils function (N/A)
  • If new assets were added or existing ones were modified, I verified that the assets are optimized and load correctly across all supported platforms (N/A)
  • If the PR modifies code that runs when editing or sending messages, I tested all supported markdown (N/A)
  • If the PR modifies a generic component, I tested all usages (N/A)
  • If the PR modifies a component related to existing Storybook stories, I tested all stories (N/A)
  • If the PR modifies a component or page accessible by direct deeplink, I verified logged-in and logged-out access (N/A)
  • If the PR modifies UI or form input styles, I verified alignment and requested Design review (N/A)
  • If the PR adds or modifies UI, I reviewed accessibility, screen-reader behavior, names/roles, and state announcements (N/A)
  • N/A — runtime unit tests: executable workflow-step fixtures passed; no persistent test added.
  • If the main branch was merged into this PR after a review, I tested again (N/A: no merge)

Screenshots/Videos

Android: Native

N/A: workflow-only change.

Android: mWeb Chrome

N/A: workflow-only change.

iOS: Native

N/A: workflow-only change.

iOS: mWeb Safari

N/A: workflow-only change.

MacOS: Chrome / Safari

N/A: workflow-only change.

@puneetlath
puneetlath requested a review from a team as a code owner October 5, 2026 20:01
@melvin-bot
melvin-bot Bot requested review from tylerkaraszewski and removed request for a team October 5, 2026 20:01
@melvin-bot

melvin-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath
puneetlath marked this pull request as draft October 5, 2026 20:12
@puneetlath
puneetlath removed the request for review from tylerkaraszewski October 5, 2026 20:12
Comment thread .github/workflows/buildAndroid.yml Outdated

AAB_FILE=$(find Mobile-Expensify/Android -path '*/outputs/bundle/*/*.aab' -print -quit 2>/dev/null || true)
if [ -z "$AAB_FILE" ]; then
AAB_FILE=$(find .rock/cache/remote-build -name '*.aab' -print -quit 2>/dev/null || true)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: We know the real ARTIFACT_PATH (it's in $GITHUB_ENV). But this seems fine

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit clearer for people to see

Julesssss
Julesssss previously approved these changes Oct 6, 2026
@Julesssss
Julesssss marked this pull request as ready for review October 6, 2026 18:14
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T18:20:03.639762Z ded3c68 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Julesssss

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@puneetlath puneetlath changed the title Fix Android release artifacts on Rock cache hits [No QA] Fix Android release artifacts on Rock cache hits Oct 6, 2026
@puneetlath
puneetlath merged commit 4cadefb into main Oct 6, 2026
19 of 20 checks passed
@puneetlath
puneetlath deleted the fix/android-rock-cache-artifacts branch October 6, 2026 18:40
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 6, 2026
100 tasks done
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.4-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mountiny

mountiny commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Seems like this is causing all adhoc builds to fail on Android

@mountiny

mountiny commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Fix here #103312

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants