Repository navigation
[No QA] Fix Android release artifacts on Rock cache hits - #103079
Conversation
|
@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| AAB_FILE=$(find Mobile-Expensify/Android -path '*/outputs/bundle/*/*.aab' -print -quit 2>/dev/null || true) | ||
| if [ -z "$AAB_FILE" ]; then | ||
| AAB_FILE=$(find .rock/cache/remote-build -name '*.aab' -print -quit 2>/dev/null || true) |
There was a problem hiding this comment.
NAB: We know the real ARTIFACT_PATH (it's in $GITHUB_ENV). But this seems fine
There was a problem hiding this comment.
This is a bit clearer for people to see
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.4-0 🚀
|
|
Seems like this is causing all adhoc builds to fail on Android |
|
Fix here #103312 |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Collect the Android AAB from Rock's exact
ARTIFACT_PATHwhen no Gradle output exists, then generate the APK from the collected AAB. A Release build now fails immediately when neither location contains an AAB instead of reporting success and leaving Google Play and BrowserStack without artifacts. Using Rock's recorded path avoids accidentally picking a different cached AAB.The failing staging run produced a signed AAB at
.rock/cache/remote-build/.../Expensify-release.aab; the workflow only searchedMobile-Expensify/Android. A fresh-build run produced the AAB underMobile-Expensify/Android/build/outputs/bundle/release/and succeeded.Fixed Issues
N/A — no issue filed; failing deploy run.
PROPOSAL: N/A
Tests
N/A - this is a change to the GH action, not a product change
Offline tests
QA Steps
androidBuild-artifactandandroid-apk-artifact.AI Tests
npx oxfmt --check .github/workflows/buildAndroid.yml,npm run lint-changed,npm run spell-changed,./.github/scripts/verifyActions.sh, andgit diff --check.PR Author Checklist
### Fixed Issues.TestssectionOffline stepssectionQA stepssectionmainbranch was merged into this PR after a review, I tested again (N/A: no merge)Screenshots/Videos
Android: Native
N/A: workflow-only change.
Android: mWeb Chrome
N/A: workflow-only change.
iOS: Native
N/A: workflow-only change.
iOS: mWeb Safari
N/A: workflow-only change.
MacOS: Chrome / Safari
N/A: workflow-only change.