Skip to content

[HOLD] [No QA] [Merge 10/7] Docs updates for E/A#101309 Add vendor search operator to search operators article - #103104

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsVendorSearchFilter
Oct 19, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsVendorSearchFilter

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for #101309.

New feature: that PR adds Vendor as an expense Search filter, both in Filters and as the vendor: search operator. It is available to everyone whose workspace uses vendor matching with QuickBooks Online, Sage Intacct, Xero, Rillet, or DualEntry. It is not gated by a beta for these integrations.

What changed in the docs: the expense operators table in Use Search Operators to Filter and Analyze lists every expense filter operator but had no vendor: row. This PR adds one row for vendor:, matching the format of the existing bank-account: row, plus a vendor filter keyword. No new sections or FAQs were added.

@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/681919
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 5, 2026
@MelvinBot
MelvinBot requested a review from a team October 5, 2026 23:41
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsVendorSearchFilter
git checkout -b claude-docsVendorSearchFilter upstream/claude-docsVendorSearchFilter
git push -u origin claude-docsVendorSearchFilter

Then you can close this PR and open a new one from your fork.

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#101309 Add vendor search operator to search operators article [No QA] Docs updates for E/A#101309 Add vendor search operator to search operators article Oct 6, 2026
@c3024

c3024 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot LGTM. Mark the PR as ready for review.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't mark this PR as ready for review. This environment blocked the gh pr ready command.

Since you're assigned, please click Ready for review at the bottom of the PR.


view run

@c3024

c3024 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot nope, I do not see an option to mark the PR as ready for review. Only those with write access to this repository can mark a draft pull request as ready for review.

So, mark it as ready for review. I verified the changes.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Sorry, I still can't mark this PR as ready for review. My environment blocks the command that does it, so the PR is still a draft.

Since you don't have write access, please ask an Expensify employee with write access to click Ready for review. You can note that you've verified the changes.


view run

@c3024

c3024 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott

I verified the changes but I cannot mark the PR as ready for review. Could you please mark the PR as ready for review?
Thanks!

@stephanieelliott
stephanieelliott marked this pull request as ready for review October 7, 2026 03:24
@stephanieelliott
stephanieelliott self-requested a review as a code owner October 7, 2026 03:24
@melvin-bot

melvin-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested review from bfitzexpensify and removed request for a team October 7, 2026 03:25
@melvin-bot

melvin-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T03:41:23.410074Z 565faaf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, well-scoped documentation update to the article Use Search Operators to Filter and Analyze (docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md). It adds a single vendor: row to the expense operators table and a vendor filter keyword to the YAML frontmatter, documenting the new Vendor search operator shipped in #101309. No new sections, headings, or FAQs were introduced, so the change is additive and low-risk.

Scores Summary

  • Readability: 9/10 - The new row mirrors the format of the existing bank-account: and transaction-status: rows exactly (clear syntax, concise description, availability caveat, realistic example). Scannable and consistent with the surrounding table.
  • AI Readiness: 9/10 - The added vendor filter keyword reflects a real search phrase, the example value (vendor:"Starbucks") is realistic, and the row reuses the full feature terminology. No heading/metadata structure was changed, so the article's single-H1, task-based heading, and internalScope all remain intact.
  • Style Compliance: 9/10 - Backtick code formatting for the operator and example is consistent with every other row. "Vendor" is treated as a feature/UI label and the availability condition is phrased deterministically, matching the governance "be literal, be exact, be consistent" rule.

Key Findings

  • Positive: The new row is fully consistent with the established table pattern (syntax / description / example), including an explicit availability caveat like the transaction-status: and bank-account: rows.
  • Positive: The keyword addition matches real search intent and is appropriately scoped; the internalScope already covers filter operators, so no metadata expansion was needed.
  • Minor: The availability caveat reads "Available only when one of your workspaces uses vendor matching." The PR description specifies this applies to QuickBooks Online, Sage Intacct, Xero, Rillet, or DualEntry. Consider whether naming the qualifying integrations (as a brief parenthetical) would reduce member confusion about when the operator appears. This is optional; the current phrasing is acceptable given table brevity constraints.
  • Nitpick: The example vendor:"Starbucks" reuses "Starbucks," which also appears in the merchant example query below the table. Not a problem, but a distinct vendor-flavored example could slightly improve clarity.

Recommendations

  • No blocking changes required; the diff complies with the governance guidelines.
  • Optional: Clarify the qualifying integrations in the availability caveat if it can be kept concise.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md - Approved. Adds one vendor: operator row and one keyword; consistent with surrounding content and governance rules.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott stephanieelliott changed the title [No QA] Docs updates for E/A#101309 Add vendor search operator to search operators article [No QA] [Merge 10/7] Docs updates for E/A#101309 Add vendor search operator to search operators article Oct 7, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Product change is still on staging, made a note to merge tomorrow

@stephanieelliott
stephanieelliott removed the request for review from bfitzexpensify October 7, 2026 04:43
@c3024

c3024 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The PR implementing this filter was reverted. So, this help doc update should be put on HOLD.

@Beamanator Beamanator changed the title [No QA] [Merge 10/7] Docs updates for E/A#101309 Add vendor search operator to search operators article [HOLD] [No QA] [Merge 10/7] Docs updates for E/A#101309 Add vendor search operator to search operators article Oct 8, 2026
@stephanieelliott
stephanieelliott merged commit 48b2708 into main Oct 19, 2026
21 of 22 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsVendorSearchFilter branch October 19, 2026 23:37
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants