Repository navigation
[HOLD] [No QA] [Merge 10/7] Docs updates for E/A#101309 Add vendor search operator to search operators article - #103104
Conversation
Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
|
@MelvinBot LGTM. Mark the PR as ready for review. |
|
I couldn't mark this PR as ready for review. This environment blocked the Since you're assigned, please click Ready for review at the bottom of the PR. |
|
@MelvinBot nope, I do not see an option to mark the PR as ready for review. Only those with write access to this repository can mark a draft pull request as ready for review. So, mark it as ready for review. I verified the changes. |
|
Sorry, I still can't mark this PR as ready for review. My environment blocks the command that does it, so the PR is still a draft. Since you don't have write access, please ask an Expensify employee with write access to click Ready for review. You can note that you've verified the changes. |
|
I verified the changes but I cannot mark the PR as ready for review. Could you please mark the PR as ready for review? |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, well-scoped documentation update to the article Use Search Operators to Filter and Analyze (docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md). It adds a single Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
Product change is still on staging, made a note to merge tomorrow |
|
The PR implementing this filter was reverted. So, this help doc update should be put on HOLD. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site update for #101309.
New feature: that PR adds Vendor as an expense Search filter, both in Filters and as the
vendor:search operator. It is available to everyone whose workspace uses vendor matching with QuickBooks Online, Sage Intacct, Xero, Rillet, or DualEntry. It is not gated by a beta for these integrations.What changed in the docs: the expense operators table in Use Search Operators to Filter and Analyze lists every expense filter operator but had no
vendor:row. This PR adds one row forvendor:, matching the format of the existingbank-account:row, plus avendor filterkeyword. No new sections or FAQs were added.@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/681919
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari