Repository navigation
Update setDraftSplitTransaction to pass transaction - #103344
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-10-07.at.19.12.38.mov |
ikevin127
left a comment
There was a problem hiding this comment.
The main problem is a 🔴 regression in DateField in the create flow. That bug is outside the split flow, so the PR's own test steps won't catch it.
PR Summary: Moving the TRANSACTION fallback out of setDraftSplitTransaction and into the callers is the right direction, and every caller on main was updated. The transaction each page now passes comes from withFullTransactionOrNotFound, which reads the TRANSACTION key on EDIT, so it matches the old getAllTransactions() lookup.
One real regression below plus a few cleanups 👇 Please tag me once ready!
|
Ready @ikevin127 |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - All 8 of my earlier comments are addressed in the code, and the new commits add four small 🟢 nits, none blocking.
|
Done. Ready. |
|
@danieldoglas Ready for you whenever @parasharrajat resolves the conflicts. |
|
Ready @danieldoglas. Let's merge this before conflicts. |
mountiny
left a comment
There was a problem hiding this comment.
Thank you, changes look fine to me
|
@MelvinBot is the failing test related to this PR? |
|
Likely unrelated, but not confirmed flaky. The failed check reports 0.9 extra mean renders when a policy member joins—not a split-edit failure. EvidenceThe test only updates policy membership. Its narrow-layout rows skip inline-edit hooks, while this PR changes split-draft editing. All eight unit-test jobs passed. Rerun the performance tests, not just the validator, to distinguish measurement noise from a repeatable regression. |
|
@parasharrajat I re-ran the test couple of times, can you please check this to verify why its failing on this branch? |
|
@mountiny All set here. |
|
Sorry more confclits, can you ping me in slack dm once you resolve it? thank you! |
|
Done @mountiny |
mountiny
left a comment
There was a problem hiding this comment.
Thank you, I appreciate it.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR only fixes and refactors how existing split-expense edits are saved, without adding new user-facing functionality, screens, or sensitive UI. |
|
No help site update needed — this PR fixes edits to existing split expenses so values persist as expected, without introducing a new workflow or making existing article instructions incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66510
PROPOSAL:
Tests
Preconditions:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
07.10.2026_20.11.59_REC.mp4