Repository navigation
Fix: just used route not available in Reuse Route in offline mode - #103484
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This PR adds a new |
99c13db to
fc37166
Compare
93e1e6b to
c9a365b
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93e1e6b136
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Pujan92 looks like this is ready for review. Can you review, please? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-10-13.at.18.15.59.mov |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.10-0 🚀
|
|
No help site update needed. This bug fix makes a just-created route appear in the Reuse route list right away, which users already expect, and no article under |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.5.12-0 🚀
|
|
No help site update needed. This bug fix makes a just-created route appear in the Reuse route list right away, which users already expect, and no article sentence describes that list (the only related line, the "recently used locations" FAQ in |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The "Reuse route" list is loaded from the server, so a route from an expense that was just created is not in the list yet. This makes the route unavailable when the user creates the next distance expense in offline mode, and the latest expense is also missing from the list.
This change saves the route of a newly created distance expense locally in Onyx right away, so it appears in the "Reuse route" list immediately, including offline mode. It covers both flows that create distance expenses: money requests (
CREATE_DISTANCE_REQUEST) and tracked expenses (TRACK_EXPENSE). Local routes are deduped by transaction ID and kept if a server list refresh lands before the expense syncs.Fixed Issues
$ #103273
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-09.at.3.04.24.AM.mov