Repository navigation
fix: hide failed scan amount in Recently Added - #103570
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c913c6579
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Ollyws , addressed the latest feedbacks, all your thanks |
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
|
I can kinda' see the benefit of showing failed receipt uploads in "Recent expenses" for visibility and easy access to them, but is this intentional? @JmillsExpensify @mountiny @grgia
If it is intentional, I'm wondering if we should make it more obvious that they've failed? Perhaps with displaying the Receipt scan failed message on them after a dot separator of the date? |
|
Hmm, good question. I am not sure if this is intentional, honestly. I agree we should either hide it or make it clearer that it failed. |
|
@trjExpensify, Thanks for checking! Could you please clarify the expected behavior here? Should we hide failed scans from Recently Added, or keep them visible and show a clear Receipt scan failed message? |
|
I think we should show it there, and yes, also make it more clear that they failed. |
|
Cool, so after the date should we add a dot separator?
|
|
Yeah @shawnborton what do you think about that? You're the OG on these patterns, pretty sure. |
|
That makes sense to me 👍 |
|
@Ollyws, I've addressed the latest feedback. Could you please take another look? Thanks! |
|
@Ollyws, friendly bump. thanks |
|
During testing, I found and fixed an edge case with the scan failure status. This is ready for review. Thanks! |
Reviewer Checklist
Screenshots/Videos |
|
Can we just say |
@JmillsExpensify, Thanks! We don’t currently have a translation key for |
|
Yes, please. Where else does that exist? I think we should making it scanning failed everywhere in the app (though out of scope for this PR, for clarity). |
@JmillsExpensify, I searched the codebase for all current usages of “Receipt scanning failed.” These are the places where it is used:
The translation keys are defined here:
The same translation keys also exist in the other supported language files. Screen.Recording.2026-10-23.at.2.02.21.PM.movThe Recently Added case from this PR is here: If the wording update is handled in a separate issue, that issue can cover this Recently Added case as well as the other usages above. This would make the wording consistent everywhere. I’m happy to take care of the separate issue if you prefer. Thanks! |
|
Yeah, let's take this in a separate issue. I'll create it, so we can keep this PR moving. Thank you for the thorough summary of where it needs to be changed. |
|
@Ollyws, could you please complete your review? Thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.21-0 🚀
|
|
No help site update is needed: this bug fix hides a misleading |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.23-0 🚀
|
|
No help site update is needed: this bug fix stops a failed scan from showing a misleading |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀
Bundle Size Analysis (Sentry): |






Explanation of Change
The Recently Added row always formatted the failed scan's placeholder amount (
0) as0.00.This change uses the existing failed-scan placeholder check to hide that amount. Explicitly confirmed zero amounts and amounts on settled reports remain visible.
Fixed Issues
$ #102963
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-09.at.4.08.44.PM_compressed.mp4
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-10-09.at.4.18.26.PM_compressed.mp4
iOS: mWeb Safari
Screen.Recording.2026-10-09.at.4.23.32.PM_compressed.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-10-16.at.3.03.54.PM.mov