Skip to content

fix: hide failed scan amount in Recently Added - #103570

Merged
arosiclair merged 13 commits into
Expensify:mainfrom
x-dev90:fix/failed-scan-recently-added-amount
Oct 26, 2026
Merged

arosiclair merged 13 commits into
Expensify:mainfrom
x-dev90:fix/failed-scan-recently-added-amount

Conversation

@x-dev90

@x-dev90 x-dev90 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Recently Added row always formatted the failed scan's placeholder amount (0) as 0.00.

This change uses the existing failed-scan placeholder check to hide that amount. Explicitly confirmed zero amounts and amounts on settled reports remain visible.

Fixed Issues

$ #102963
PROPOSAL:

Tests

  1. Open a workspace chat.
  2. Create a Scan expense using a receipt that will fail SmartScan.
  3. Wait for the scan to fail.
  4. Navigate to Home.
  5. Verify the expense appears under Recently Added.
  6. Verify no amount is displayed.
  7. Verify Receipt scanning failed appears after the date.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-10-09.at.4.08.44.PM_compressed.mp4
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-10-09.at.4.18.26.PM_compressed.mp4
iOS: mWeb Safari
Screen.Recording.2026-10-09.at.4.23.32.PM_compressed.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-10-16.at.3.03.54.PM.mov

@melvin-bot
melvin-bot Bot requested review from Ollyws and dylanexpensify and removed request for a team October 9, 2026 12:29
@melvin-bot

melvin-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 9, 2026 12:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T12:41:12.750309Z 5c913c6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c913c6579

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@x-dev90

x-dev90 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

@Ollyws , addressed the latest feedbacks, all your thanks

dylanexpensify
dylanexpensify previously approved these changes Oct 12, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective 👍

@trjExpensify

trjExpensify commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

I can kinda' see the benefit of showing failed receipt uploads in "Recent expenses" for visibility and easy access to them, but is this intentional? @JmillsExpensify @mountiny @grgia

image

If it is intentional, I'm wondering if we should make it more obvious that they've failed? Perhaps with displaying the Receipt scan failed message on them after a dot separator of the date?

@mountiny

Copy link
Copy Markdown
Contributor

Hmm, good question. I am not sure if this is intentional, honestly. I agree we should either hide it or make it clearer that it failed.

@x-dev90

x-dev90 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

@trjExpensify, Thanks for checking! Could you please clarify the expected behavior here? Should we hide failed scans from Recently Added, or keep them visible and show a clear Receipt scan failed message?

Copy link
Copy Markdown
Contributor

I think we should show it there, and yes, also make it more clear that they failed.

@trjExpensify

Copy link
Copy Markdown
Contributor

Cool, so after the date should we add a dot separator?

Oct 14 · Receipt scan failed

Copy link
Copy Markdown
Contributor

Yeah @shawnborton what do you think about that? You're the OG on these patterns, pretty sure.

@shawnborton

Copy link
Copy Markdown
Contributor

That makes sense to me 👍

@x-dev90

x-dev90 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

@Ollyws, I've addressed the latest feedback. Could you please take another look? Thanks!

@x-dev90

x-dev90 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

@Ollyws, friendly bump. thanks

@x-dev90

x-dev90 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

During testing, I found and fixed an edge case with the scan failure status. This is ready for review. Thanks!

@Ollyws

Ollyws commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Android_Native
Android: mWeb Chrome Android_Chrome
iOS: HybridApp iOS_Native
iOS: mWeb Safari iOS_Safari
MacOS: Chrome / Safari MacOS_Chrome

Copy link
Copy Markdown
Contributor

Can we just say Scanning failed for simplicity? We can add more words later if needed.

@x-dev90

x-dev90 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Can we just say Scanning failed for simplicity? We can add more words later if needed.

@JmillsExpensify, Thanks! We don’t currently have a translation key for Scanning failed. If you prefer this wording, I’ll add one specifically for Recently Added. Please let me know.

JmillsExpensify commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Yes, please. Where else does that exist? I think we should making it scanning failed everywhere in the app (though out of scope for this PR, for clarity).

@x-dev90

x-dev90 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Yes, please. Where else does that exist? I think we should making it scanning failed everywhere in the app (though out of scope for this PR, for clarity).

@JmillsExpensify, I searched the codebase for all current usages of “Receipt scanning failed.”

These are the places where it is used:

  1. Receipt scan failed report activity message
    ReceiptScanFailedContent.tsx:49

  2. Violation message formatting
    ViolationsUtils.ts:1296

  3. Report name/message formatting
    ReportNameUtils.ts:649

  4. Report alternate text/accessibility text
    ReportAlternateTextUtils.ts:767

  5. Copy message from the report context menu
    ContextMenuActions.tsx:1578

  6. Search violation display formatting
    SearchUIUtils.ts:5228

  7. Recently Added message
    RecentlyAddedRow.tsx:85

The translation keys are defined here:

The same translation keys also exist in the other supported language files.

Screen.Recording.2026-10-23.at.2.02.21.PM.mov

The Recently Added case from this PR is here:

RecentlyAddedRow.tsx:85

If the wording update is handled in a separate issue, that issue can cover this Recently Added case as well as the other usages above. This would make the wording consistent everywhere.

I’m happy to take care of the separate issue if you prefer.

Thanks!

Copy link
Copy Markdown
Contributor

Yeah, let's take this in a separate issue. I'll create it, so we can keep this PR moving. Thank you for the thorough summary of where it needs to be changed.

@x-dev90

x-dev90 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@Ollyws, could you please complete your review? Thanks!

@Ollyws Ollyws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from arosiclair October 26, 2026 17:13
@arosiclair
arosiclair merged commit 50b0773 into Expensify:main Oct 26, 2026
35 of 37 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.21-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed: this bug fix hides a misleading 0.00 placeholder on failed scans in Recently added, and no help article describes the amounts shown in that section.


view run

@github-actions

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.23-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed: this bug fix stops a failed scan from showing a misleading 0.00 amount in Recently added, and no help article describes the amounts shown in that section.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants