Skip to content

fix: show an error when importing per diem rates without a per diem unit - #103605

Merged
Julesssss merged 7 commits into
Expensify:mainfrom
callstack-internal:fix/per-diem-import-missing-unit-error
Oct 19, 2026
Merged

Julesssss merged 7 commits into
Expensify:mainfrom
callstack-internal:fix/per-diem-import-missing-unit-error

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Some workspaces have per diem turned on, but they do not have a Per Diem International custom unit. On these workspaces, the import of per diem rates stopped and showed nothing to the user.

This PR adds a validation error to the import page when the unit is missing. The error tells the user to contact Concierge. The App does not send the import request.

The backend fix in Web-Expensify#56337 stops new workspaces from getting into this state.

This PR adds only the English text. The translation action adds the other languages.

Fixed Issues

$ #101066
PROPOSAL: #101066 (comment)

Tests

You cannot make this workspace state from the UI. Step 3 makes it in the local cache only.

  1. Open a workspace that has per diem rates.
  2. Go to Per diem.
  3. In the browser console, run this code:
    const id = '<policyID>';
    const policy = await Onyx.get(`policy_${id}`);
    const unit = Object.values(policy.customUnits).find((u) => u.name === 'Per Diem International');
    Onyx.merge(`policy_${id}`, {customUnits: {[unit.customUnitID]: null}});
  4. Select More > Import spreadsheet.
  5. Upload a CSV file with the Destination, Subrate, Currency and Amount columns.
  6. Map the four columns and select Import.
  7. Make sure that this error shows: "Per diem isn't set up correctly on this workspace. Please reach out to Concierge for help."
  8. Make sure that the App does not send an ImportPerDiemRates request.
  9. Reload the page and import the CSV file again.
  10. Make sure that the App imports the rates.
  • Verify that no errors appear in the JS console

Offline tests

The check runs in the App, so the result is the same when you are offline.

  1. Go offline.
  2. Do steps 1 to 6 of Tests.
  3. Make sure that the same error shows.

QA Steps

QA cannot make a workspace in this state on staging. The unit test in tests/ui/ImportedPerDiemPageTest.tsx covers the error.

Do these steps to make sure that the import still works:

  1. Open a workspace that has per diem turned on.
  2. Go to Per diem.
  3. Select More > Import spreadsheet.
  4. Upload a CSV file with the Destination, Subrate, Currency and Amount columns.
  5. Map the four columns and select Import.
  6. Make sure that the App imports the rates and shows no error.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari image

@melvin-bot

melvin-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@BartekObudzinski

Copy link
Copy Markdown
Contributor Author

Need confirmation for the translation for the error message and then run the parrot 🙏

@BartekObudzinski

Copy link
Copy Markdown
Contributor Author

I'm off next week, @TMisiukiewicz will take care of this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index c7e2a8e9..a2ac9159 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5034,6 +5034,7 @@ ${amount} für ${merchant} – ${date}`,
             editPerDiemRates: 'Pauschalvergütungssätze bearbeiten',
             editDestinationSubtitle: (destination: string) => `Wenn Sie dieses Ziel aktualisieren, wird es für alle ${destination}-Tagespauschalen-Teilbeträge geändert.`,
             editCurrencySubtitle: (destination: string) => `Wenn Sie diese Währung aktualisieren, wird sie für alle ${destination}-Tagesgeld-Teilbeträge geändert.`,
+            missingPerDiemUnit: 'Per Diem ist in diesem Workspace nicht korrekt eingerichtet. Bitte wenden Sie sich für Hilfe an Concierge.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Legen Sie fest, wie aus eigener Tasche bezahlte Ausgaben nach QuickBooks Desktop exportiert werden.',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 58b75f9c..69b86161 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -5105,6 +5105,7 @@ ${amount} για ${merchant} - ${date}`,
                 subtitle: 'Αυτός ο χώρος εργασίας δεν έχει ημερήσια επιδόματα· ζητήστε από τον διαχειριστή σας να προσθέσει κάποια.',
                 adminSubtitle: 'Προσθέστε ημερήσια επιδόματα για να οργανώσετε τις δαπάνες σας.',
             },
+            missingPerDiemUnit: 'Το ημερήσιο επίδομα δεν έχει ρυθμιστεί σωστά σε αυτόν τον χώρο εργασίας. Παρακαλούμε επικοινωνήστε με το Concierge για βοήθεια.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Ορίστε πώς θα εξαχθούν οι εκτός τσέπης δαπάνες στο QuickBooks Desktop.',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 059f2f0b..c7c925cc 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -4956,6 +4956,7 @@ ${amount} para ${merchant} - ${date}`,
             editPerDiemRates: 'Editar las tasas de per diem',
             editDestinationSubtitle: (destination) => `Actualizar este destino lo modificará para todas las subtasas per diem de ${destination}.`,
             editCurrencySubtitle: (destination) => `Actualizar esta moneda la modificará para todas las subtasas per diem de ${destination}.`,
+            missingPerDiemUnit: 'El per diem no está configurado correctamente en este espacio de trabajo. Ponte en contacto con Concierge para obtener ayuda.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Establezca cómo se exportan los gastos de bolsillo a QuickBooks Desktop.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d9ffc721..2cb25846 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5040,6 +5040,7 @@ ${amount} pour ${merchant} - ${date}`,
             editPerDiemRates: 'Modifier les taux de per diem',
             editDestinationSubtitle: (destination: string) => `La mise à jour de cette destination la modifiera pour tous les sous-taux de per diem ${destination}.`,
             editCurrencySubtitle: (destination: string) => `La mise à jour de cette devise la modifiera pour tous les sous-taux de per diem de ${destination}.`,
+            missingPerDiemUnit: 'Le per diem n’est pas configuré correctement sur cet espace de travail. Veuillez contacter Concierge pour obtenir de l’aide.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Définissez comment les dépenses hors poche sont exportées vers QuickBooks Desktop.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 7731e58e..fe342e5c 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5002,6 +5002,7 @@ ${amount} per ${merchant} - ${date}`,
             editPerDiemRates: 'Modifica le tariffe di diaria',
             editDestinationSubtitle: (destination: string) => `L’aggiornamento di questa destinazione la modificherà per tutte le sottotariffe di diaria ${destination}.`,
             editCurrencySubtitle: (destination: string) => `L’aggiornamento di questa valuta la modificherà per tutte le sottotariffe di diaria ${destination}.`,
+            missingPerDiemUnit: 'Il per diem non è configurato correttamente in questo workspace. Contatta Concierge per ricevere aiuto.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Imposta come esportare le spese anticipate in QuickBooks Desktop.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 11390508..6b745f51 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4966,6 +4966,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
             editPerDiemRates: '日当レートを編集',
             editDestinationSubtitle: (destination: string) => `この行き先を更新すると、すべての ${destination} 日当サブレートに適用されます。`,
             editCurrencySubtitle: (destination: string) => `この通貨を更新すると、すべての${destination}の日当サブレートの通貨が変更されます。`,
+            missingPerDiemUnit: 'このワークスペースでは日当が正しく設定されていません。ヘルプが必要な場合は Concierge までお問い合わせください。',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: '自己負担経費を QuickBooks Desktop にエクスポートする方法を設定します。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c75f66c9..cb37a2e5 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5002,6 +5002,7 @@ ${amount} voor ${merchant} - ${date}`,
             editPerDiemRates: 'Dagvergoedingen bewerken',
             editDestinationSubtitle: (destination: string) => `Als je deze bestemming bijwerkt, wordt deze gewijzigd voor alle per diem-deeltarieven van ${destination}.`,
             editCurrencySubtitle: (destination: string) => `Als u deze valuta bijwerkt, wordt deze gewijzigd voor alle ${destination} daggeldsubtarieven.`,
+            missingPerDiemUnit: 'Per diem is niet goed ingesteld in deze workspace. Neem contact op met Concierge voor hulp.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Stel in hoe contante uitgaven worden geëxporteerd naar QuickBooks Desktop.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 24c6e373..27ab44d4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5031,6 +5031,7 @@ ${amount} dla ${merchant} - ${date}`,
             editPerDiemRates: 'Edytuj stawki diet',
             editDestinationSubtitle: (destination: string) => `Zaktualizowanie tego miejsca docelowego zmieni je dla wszystkich podstawek diet ${destination}.`,
             editCurrencySubtitle: (destination: string) => `Zaktualizowanie tej waluty spowoduje jej zmianę dla wszystkich podrzędnych stawek diet w ${destination}.`,
+            missingPerDiemUnit: 'Dieta nie jest poprawnie skonfigurowana w tym workspace. Skontaktuj się z Concierge, żeby uzyskać pomoc.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Ustaw sposób eksportu wydatków z własnej kieszeni do QuickBooks Desktop.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6932fb13..c648f8a6 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4994,6 +4994,7 @@ ${amount} para ${merchant} - ${date}`,
             editPerDiemRates: 'Editar diárias',
             editDestinationSubtitle: (destination: string) => `Atualizar este destino irá alterá-lo para todas as subdiárias de ${destination}.`,
             editCurrencySubtitle: (destination: string) => `Atualizar esta moeda irá alterá-la para todas as subdiárias de ${destination}.`,
+            missingPerDiemUnit: 'O per diem não está configurado corretamente neste workspace. Fale com o Concierge para obter ajuda.',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: 'Defina como as despesas reembolsáveis serão exportadas para o QuickBooks Desktop.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index fd490a4f..262e8f64 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4848,6 +4848,7 @@ ${amount},商户:${merchant} - 日期:${date}`,
             editPerDiemRates: '编辑每日津贴费率',
             editDestinationSubtitle: (destination: string) => `更新此目的地将会更改所有 ${destination} 按日津贴子费率的设置。`,
             editCurrencySubtitle: (destination: string) => `更新此货币将会更改所有 ${destination} 的每日津贴子费率。`,
+            missingPerDiemUnit: '此工作区的每日津贴设置不正确。请联系 Concierge 获取帮助。',
         },
         qbd: {
             exportOutOfPocketExpensesDescription: '设置自掏腰包报销如何导出到 QuickBooks Desktop。',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@mountiny
mountiny marked this pull request as ready for review October 12, 2026 10:48
@mountiny
mountiny requested review from a team as code owners October 12, 2026 10:48
@melvin-bot
melvin-bot Bot requested review from huult and trjExpensify and removed request for a team October 12, 2026 10:48
@melvin-bot

melvin-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 12, 2026 10:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T11:00:13.667506Z 2508db1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread tests/ui/ImportedPerDiemPageTest.tsx Outdated
name: SCREENS.WORKSPACE.PER_DIEM_IMPORTED,
params: {policyID: POLICY_ID},
};
// The screen does not read navigation; this inert test double only satisfies the navigator-provided prop.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-15 (docs)

The comment joins two independent sentences with a semicolon, which the plain-comment-style rule calls out. Comments should read as plain, natural sentences rather than semicolon-joined clauses.

Split it into two sentences:

// The screen does not read navigation. This inert test double only satisfies the navigator-provided prop.
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
const navigation = {} as ImportedPerDiemPageScreenProps['navigation'];

Reviewed at: 2508db1 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny (and maybe @twisterdotcom), why don't workspaces with Per Diem all have
PerDiemInternational custom unit? How do workspaces end up like that, and should we be rectifying that with a migration instead of coding around it with error messages like this:

"Per diem isn't set up correctly on this workspace. Please reach out to Concierge for help."

@huult

huult commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@BartekObudzinski Please tag me when the PR is ready for review.

@mountiny

Copy link
Copy Markdown
Contributor

Yeah I agree that we should make sure we clear up the data that is in wrong state, based on https://github.com/Expensify/Web-Expensify/pull/56337 @hungvu193 the gap where such policies were created is closed so we should be able to find policies where arePerDiemsEnabled is true and they do not have this per diem field set and fix it

@mountiny

Copy link
Copy Markdown
Contributor

@hungvu193 is that the only path such policies been created through?

@hungvu193

Copy link
Copy Markdown
Contributor

@hungvu193 is that the only path such policies been created through?

Yeah. But we already closed the gap.

@TMisiukiewicz

Copy link
Copy Markdown
Contributor

@huult can you review please? 🙏

@huult

huult commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@TMisiukiewicz could you sync with main?

@TMisiukiewicz

Copy link
Copy Markdown
Contributor

done!

@huult

huult commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review this

@MelvinBot

Copy link
Copy Markdown
Contributor

Code review

The change looks correct. I found no blocking issues.

  • ImportedPerDiemPage.tsx:110-112 adds the error after the column checks. The errors = {} reset on line 107 can't remove it. The early return on line 125 keeps the ImportPerDiemRates call blocked.
  • OfflineWithFeedback in ImportSpreadsheetColumns.tsx:117-121 shows the new error key above the Import button.
  • The tests cover both cases: no unit, so no API call, and a valid unit, so the API gets the right customUnitID. They follow the Given/When/Then rule.
  • The English copy uses isn't, the same apostrophe style as nearby double-quoted strings in en.ts. The other 10 locales add the key in the same workspace.perDiem block.

Optional suggestion: Users see the error only after they upload a file and map every column. You could check for the unit at the entry point in WorkspacePerDiemPage.tsx:228-234 and :366-372. Then users wouldn't do the work for nothing. If the data cleanup in this thread fixes every affected workspace, the current approach is enough.

I reviewed the code only and did not run the test steps.


view run

@twisterdotcom

Copy link
Copy Markdown
Contributor

why don't workspaces with Per Diem all have PerDiemInternational custom unit?

We did the migration for this a long time ago, so they absolutely should.

@trjExpensify

Copy link
Copy Markdown
Contributor

Cool, so I think we need to query and do another migration then?

@huult

huult commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Since the affected policies will be fixed with a migration, do we still need this safeguard? @mountiny @trjExpensify

@huult

huult commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Since the affected policies will be fixed with a migration, do we still need this safeguard in the app? @mountiny @trjExpensify

@mountiny

Copy link
Copy Markdown
Contributor

@huult yeah I think we put this in place and remove once the policies are migrated because we dont have this migration ready yet

@mountiny

Copy link
Copy Markdown
Contributor

@MelvinBot, can you create an internal issue to backfill the PerDiemInternational in policies where it's missing?

@MelvinBot

Copy link
Copy Markdown
Contributor

I created an internal issue to backfill the PerDiemInternational custom unit on workspaces that have per diem turned on but don't have the unit. It links back to this PR, so you can find it in this PR's timeline if you have access.

The issue covers how to find the affected workspaces, how to check that no new ones appear, how to back up and test the backfill, and how to confirm it worked. When the backfill is done, you can remove the temporary error that this PR adds. The issue has no assignee yet.


view run

@huult

huult commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-10-16.at.09.27.33.mov

@huult huult left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot
melvin-bot Bot requested a review from Julesssss October 16, 2026 02:32
@Julesssss
Julesssss merged commit 822acbf into Expensify:main Oct 19, 2026
36 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.15-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR only adds an in-app error to the per diem import page for a rare broken workspace setup, and the error message explains itself.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants