Repository navigation
Remove getReportTransactions callers' reliance on the deprecated default in submitReport (Part 9) - #103683
Conversation
…ult in submitReport (Part 9) submitReport now takes the report's transactions as an explicit param instead of falling back to the deprecated Onyx.connect-backed global. The submit buttons and lifecycle actions pass the transactions they already have, and ReportSubmitToContent adds useReportTransactions.
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dylanexpensify
left a comment
There was a problem hiding this comment.
Product input not needed.
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-10-20.at.13.57.02.mov |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.16-0 🚀
|
|
No help site update is needed. This PR is an internal refactor: |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.18-0 🚀
|
|
No help site update is needed. This PR is an internal refactor: |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Part 9 of the effort to remove the deprecated,
Onyx.connect-backedgetReportTransactionsglobal (#66418).submitReportinReportWorkflow.tsused to callgetReportTransactions(expenseReport.reportID)internally to find held expenses (to decide whether to bail out when the report only has held expenses, and to split out held expenses on submit). This PR makes that an explicit input instead:expenseReportTransactions: OnyxTypes.Transaction[]param toSubmitReportFunctionParams, and uses it in place of the global lookup for the held-expense checks (isOnHoldfilter andhasOnlyHeldExpenses).SubmitPrimaryAction,SubmitActionButtonanduseLifecycleActionspass their existingtransactions;ReportSubmitToContentaddsuseReportTransactions(report?.reportID)and passes the result.@typescript-eslint/no-deprecated/getReportTransactionscount forReportWorkflow.tsfrom 3 to 2 ineslint.seatbelt.tsv.ReportWorkflowTest.ts: adds agetReportTransactionsFromOnyxhelper and passesexpenseReportTransactionsto everysubmitReportcall (explicit[transaction]/[]where the test has no Onyx transactions).No user-facing behavior change is intended.
Fixed Issues
$ #66418
PROPOSAL: N/A
Tests
Offline tests
Same as test
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-10-14.at.15.34.27.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-14.at.15.31.03.mov