Repository navigation
Conversation
…tion submission hooks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot review |
ReviewThe refactor looks safe to merge once the description is filled in. I compared every moved block with the original and found no behavior change. Two small suggestions:
Also, the PR body still needs the Explanation of Change, Tests, and QA sections. What I checked
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@situchan seems like this is ready for your review. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaritest.mov |
|
Hey @situchan, how is it going? |
|
Almost done |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
No issues found. Let's also get 2nd 👁️ from bots |
|
@codex review |
|
@MelvinBot review |
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| if (hasSubmitIntent || formHasBeenSubmitted.current) { |
There was a problem hiding this comment.
Likely dead eslint-disable
exhaustive-deps only flags .current in cleanup for a local useRef. formHasBeenSubmitted is now a param.
Fix: remove it, or add a justification if lint still needs it.
There was a problem hiding this comment.
It triggered lint error, so I just added a comment in 19e1f5b
ReviewNo blocking issues. I reviewed the two commits added since my last review and found no behavior change.
Two PR body nits:
CI is green except the checklist and approval checks, which wait on reviewers. |
Regression checkI found no regressions. I compared every moved block with the base page at I found one low-risk difference to be aware of:
What I compared
I compared the code only. I didn't run the app. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@VickyStash can you please check the comments from @situchan ? thanks |
|
@mountiny Done! |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.14-0 🚀
|
|
No help site update is needed. This PR only restructures |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.14-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR prepares
IOURequestStepConfirmationfor the split per submission path. It doesn't change behavior.IOURequestStepConfirmation/index.tsx, and its props types move totypes.ts.useConfirmationTransactionPagertracks which transaction is shown and handles prev/next and remove.useParticipantPickerStateowns the in-place "To" picker and what picking a participant writes to the transaction.useSubmitDestinationPreMountresolves the report the expense lands on and pre-mounts it.useSubmitLockholdsisConfirmedandformHasBeenSubmitted. They lived insideuseExpenseSubmission, but the page reads them as well, so the page now creates the lock and passes it in.useExpenseSubmissionnow uses two small helpers that the per-path variants will share in the next PR:guardSubmissionruns the checks before a submit: span tag, distance block, then the lock.useSubmissionOnboardingIntentreturns the onboarding flags that decide where an expense lands.The next PR will fork the page into one variant per submission path, so each confirmation mounts only the submission hook it uses.
Fixed Issues
$ #99449
PROPOSAL: N/A
Tests
Offline tests
Same, as in Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
FAB creation + change participants + double-click:
FAB+double-click.mp4
Pay:
pay1.mp4
Invoice:
invoice1.mp4
Multi-scan:
multi-scan.mp4
Distance:
distance1.mp4