Repository navigation
Dismiss action badge pill when composer is expanded - #103752
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Bunch of tests failing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c457be617
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Fixed. job 3, job 7 still failing but unrelated. Happening on |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.mp4iOS: mWeb Safarimsafari.mp4MacOS: Chrome / Safariweb.mov |
|
Bug: "Latest messages" pill is missing after collapsing the composer until scroll again bug.mp4 |
|
@MelvinBot review |
ReviewVerdict: The approach works for the reported bug, but it causes the regression you found. Please fix that before merging. 🐛 "Latest messages" pill stays hidden after you collapse the composerCause: While the composer is expanded, scroll events still update The unread-marker pill and the action badge pill recover by themselves. The full-size footer ( Suggested fix: Recheck the pill when the composer collapses. const prevIsComposerFullSize = usePrevious(isComposerFullSize);
// Scroll events skipped pill tracking while expanded, so sync the Latest messages pill with the current offset
const syncPillAfterComposerCollapse = useEffectEvent(() => {
if (!prevIsComposerFullSize || isComposerFullSize || shouldDisablePillTracking) {
return;
}
updatePillVisibility();
});
useEffect(() => {
syncPillAfterComposerCollapse();
}, [isComposerFullSize]);Please add a unit test for the collapse case: expanded → collapsed with Other notes (no action needed)
I reviewed the code only. I didn't run the app, because your video already reproduces the bug. |
Fixed |
|
Bug (iOS): after following Tests steps and collapsing composer, Submit pill should be clicked twice to scroll up to the submit preview ios.mp4The same bug also happens on main/staging so I think we can consider this out of scope Repro step:
Expected: Chat is scrolled to the top so that report preview shows ios-main.mp4 |
|
@MelvinBot review |
ReviewVerdict: The new commit fixes the "Latest messages" pill regression. One small request: add a unit test for it. I found no other issues.
|
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
Regression checkVerdict: I found one low-severity regression. It's an edge case, so fixing it is optional. Nothing else in the current diff changes behavior outside the expanded-composer flow.
|
Agree edge case and not blocker |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6560f8092
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| unreadMarkerReportActionIndex, | ||
| isInverted: true, | ||
| // The list is hidden behind the expanded composer, so scrolling it must not bring the Latest messages pill back | ||
| shouldDisablePillTracking: shouldDisablePillTracking || isComposerFullSize, |
There was a problem hiding this comment.
Gate pill tracking on the rendered composer
When an expanded report stops rendering its composer without one of the composer handlers running—for example, an unresolved support ticket goes offline or a room is remotely archived/blocked—the REPORT_IS_COMPOSER_FULL_SIZE Onyx value remains true because all of its clear calls live in the now-unmounted composer. This expression consequently keeps scroll-based pill tracking disabled even though ReportFooter has exposed the action list, so scrolling history cannot show or hide the Latest messages pill until the composer becomes available and is manually collapsed; gate this on the composer actually being rendered, or clear the flag when the footer hides it.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #92650 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.10-0 🚀
|
|
No help site update needed. This is a bug fix: clicking a floating action pill (for example, Submit) while the composer is expanded now dismisses the pill as users would expect, and no article under |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.12-0 🚀
|
|
No help site update needed. The code hasn't changed since my earlier review: this bug fix makes a floating action pill (for example, Submit) dismiss when clicked while the composer is expanded, which is what users already expect, and no article under |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The action badge pill only hides once its target becomes viewable.
The expanded composer covers the list, so the target never becomes viewable and the pill stays after being clicked.
Now clicking it while the composer is expanded dismisses it, and scroll-based tracking of the Latest messages pill is paused while expanded so the scroll doesn't bring that pill back.
Fixed Issues
$ #92650
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test.mov