Repository navigation
[Payment due @Krishna2323] Keep the rule editor's form when Describe returns another rule type - #103809
Conversation
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
20f7d14 to
72d7c12
Compare
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective 👍
|
Reviewing... |
|
@yuwenmemon could you please add a precondition to the QA section asking them to enable the |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
There was a problem hiding this comment.
LGTM!
Please check this comment before merging. Thanks!
|
🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
72d7c12 to
ee93237
Compare
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.10-0 🚀
|
|
No help site update needed. This PR fixes a bug in the Describe rule modal, and that modal is only available behind the |
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.12-0 🚀
|
|
No help site update needed. This PR fixes a bug in the Describe rule modal, which is still only available behind the |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104213 |
@puneetlath please review
Explanation of Change
Each rule editor's Describe button asks GenerateRule for that editor's rule type, but the model picks the type from the description. When it answers with another type, for example a card restriction typed into the Flag for review editor, the modal wrote those values into the open editor's draft and wiped the form. The modal now shows the existing "That rule isn't supported yet" error for an answer of another rule type, and leaves the form alone.
ruleTypereturns to theGeneratedRuletype. The answer already carries it, and this check is its reader.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/683436
PROPOSAL: N/A
Tests
Offline tests
QA Steps
Precondition: Enable the
describeRulebeta on the test account. Without it, the rule editors don't show the Describe button.Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari