Skip to content

Show workspace name in per diem empty state for members - #103972

Merged
neil-marcellini merged 7 commits into
mainfrom
claude-perDiemEmptyStateWorkspaceName
Oct 14, 2026
Merged

neil-marcellini merged 7 commits into
mainfrom
claude-perDiemEmptyStateWorkspaceName

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When a workspace member opens the Per diem tab and the workspace has no per diem rates, the empty state said "This workspace…". Members can belong to several workspaces, so this change names the workspace instead.

  • workspace.perDiem.requestEmptyList.subtitle now takes the workspace name in every locale. The English copy follows the marketing-approved wording: "[workspaceName] doesn't have any per diem rates. Ask an admin to add some."
  • DynamicIOURequestStepDestination passes policy?.name to the member subtitle. The admin subtitle and the title stay the same.

Fixed Issues

$ #103898
PROPOSAL: #103898 (comment)

Tests

  1. As User A create a WS and enable Per diem without adding any per diem rate
  2. Invite a member(User B) (who doesn't have any WS enables Per diem)
  3. As User B, go FAB > Create expense > Per diem
  4. Make sure you see this description: [workspaceName] doesn't have any per diem rates. Ask an admin to add some.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 14, 2026 09:53
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 14, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I don't have push access to your fork.

To take over this branch and push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-perDiemEmptyStateWorkspaceName
git checkout -b claude-perDiemEmptyStateWorkspaceName upstream/claude-perDiemEmptyStateWorkspaceName
git push -u origin claude-perDiemEmptyStateWorkspaceName

Then you can close this PR and open a new one from your fork.

@OSBotify

This comment has been minimized.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
.../request/step/DynamicIOURequestStepDestination.tsx 2.17% <0.00%> (ø)
... and 11 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The failing typecheck check is unrelated to this PR. main itself is broken, so I didn't push a change here.

Analysis: refactor: thread hasCompletedGuidedSetupFlow through navigateToConciergeChat merged today at 09:30 UTC. It added a hasCompletedGuidedSetupFlow parameter to openReportFromDeepLink (src/libs/actions/Link.ts:436). It did not update the call in tests/unit/LinkTest.ts:424, which still passes 9 arguments:

tests/unit/LinkTest.ts(424,9): error TS2554: Expected 10 arguments, but got 9.

Evidence: This PR changes only src/languages/*.ts and DynamicIOURequestStepDestination.tsx. The failing line is identical on main at 33c3234, the commit this branch is built on.

Next step: Once main has the fix (one extra argument at LinkTest.ts:424), merge main into this branch and re-run the checks. Check independent approval is also failing, but that check only needs a reviewer's approval.


view run

@MelvinBot

MelvinBot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ⚠️ partial

Verified on standalone Android NewDot: admin can create a workspace, enable Per diem with no rates, and the admin-side Per diem empty state is unchanged ("No per diem rates yet" / "Add per diem rates to organize your spend."). Could not verify the member-facing subtitle text change because Melvin's Android tester only supports one session/account per run and cannot sign in as a second (member) user.

Admin FAB > Create expense > Per diem empty state showing unchanged admin subtitle

Step Status
VERIFY 1: As admin, create a workspace and enable Per diem without adding any rateCompleted onboarding as admin and enabled Per diem on the new workspace. Workspace Settings > Per diem shows the empty state "Set per diem rates to control daily employee spend. Import rates from a spreadsheet to get started." with an "Import spreadsheet" button and no rates listed.
Admin workspace settings Per diem page showing no rates
✅
VERIFY 2: Invite a member account to that workspace (member has no other Per diem-enabled workspace)Not completed: this run has exactly one signed-in account (the admin). The tester cannot sign in as a second user to act as the invited member. This is a test-environment limit, not an app failure.
❌
VERIFY 3: As the member, FAB > Create expense > Per diem shows the empty pageNot completed: requires acting as the member account, which this single-account run cannot reach.
❌
VERIFY 4: Member's empty-state subtitle names the workspace and does not say "This workspace"Not completed: requires the member's own view, which this single-account run cannot reach. No evidence either way on the member-facing string.
❌
VERIFY 5 (regression): As admin, Per diem empty state still shows the unchanged admin subtitleFAB > Create expense > Per diem (admin account) shows title "No per diem rates yet" and subtitle "Add per diem rates to organize your spend." with an "Edit per diem rates" button. This matches the unchanged admin copy, with no workspace name substitution.
Admin FAB > Create expense > Per diem empty state showing unchanged admin subtitle
✅

view run · view recording

@MelvinBot

MelvinBot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

Verified as workspace admin: Per diem can be enabled with no rates, a member was invited, and the admin empty-state subtitle is unchanged. Could not verify the member-facing subtitle text (VERIFY 3/4) because that requires driving a second (member) account, which is unsupported in this single-session web harness.

Members list showing invited member with role Member

Step Status
VERIFY 1: As admin, create a workspace and enable Per diem without adding any rateCreated the workspace during onboarding. The More features page shows Per diem turned on (after upgrading to the Control plan). The workspace Per diem page shows the empty "Import spreadsheet" prompt with no rates.
More features page with Per diem toggle enabled
Workspace Per diem settings page showing no rates
✅
VERIFY 2: Invite a member account to the workspace (no other workspace with Per diem for that member)Invited melvinbottestuser+perdiem_member_test@gmail.com with the Member role. The members list shows 2 members, with the new address as Member. This is a new address with no other workspaces.
Members list showing invited member with role Member
✅
VERIFY 3: As the member, FAB > Create expense > Per diem shows the empty pageNot completed: acting as the invited member needs a second signed-in account. This run supports only one account, so this is a test-environment limit, not an app failure.
❌
VERIFY 4: Member's empty-state subtitle names the workspace and does not say "This workspace"Not completed for the same reason as VERIFY 3. No evidence either way on the member-facing string.
❌
VERIFY 5 (regression): As admin, Per diem empty state still shows the unchanged admin subtitleFAB > Create expense > Per diem shows the title "No per diem rates yet" and the subtitle "Add per diem rates to organize your spend." This matches the unchanged admin copy, with no "This workspace" wording.
Admin Create expense Per diem empty state with unchanged admin subtitle
✅

view run · view recording

@Eskalifer1

Copy link
Copy Markdown
Contributor

@MelvinBot implement this Polyglot diff: #103972 (comment)

Comment thread src/languages/en.ts Outdated
requestEmptyList: {
title: 'No per diem rates yet',
subtitle: "This workspace doesn't have any per diem rates, ask your Admin to add some.",
subtitle: (workspaceName: string) => `${workspaceName} doesn't have any per diem rates. Ask an admin to add some.`,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot If policy?.name is missing, the ?? '' fallback renders the subtitle with no subject (" doesn't have any per diem rates..."). The old copy read fine in that state, so this is a small regression for it.

Let's use fallback here as This workspace ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in dac2731. When the workspace name is missing, members now see "This workspace doesn't have any per diem rates. Ask an admin to add some."

  • subtitle now takes an optional workspaceName in every locale. It uses the named copy when a name is present and the "This workspace" copy when it isn't. Each locale's fallback keeps that locale's named sentence and swaps in its own word for "this workspace".
  • DynamicIOURequestStepDestination.tsx:259 now passes policy?.name without the ?? ''. An empty name also falls back.

Typecheck, lint, and spellcheck pass. I couldn't run oxfmt here, so I wrapped the lines by hand to match the 190-character limit.


view run

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I applied the Polyglot translation diff in 393473a. It updates the per diem empty-state subtitle in de, el, es, it, ja, nl, pl, pt-BR, and zh-hans.

The pushed changes match the Polyglot diff line for line. I did not run lint or spell checks locally because the tools are not set up in my checkout. CI will run them on this push.

…ateWorkspaceName

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged main into this branch in 9e5bb02, which should fix the failing typecheck check. npm run typecheck passes locally.

The typecheck failure came from main, not this PR. [No QA] Fix missing onboarding argument in LinkTest has since fixed main, and the merge brings that fix into this branch. The merge changes only tests/unit/LinkTest.ts:424.

The remaining failing check, Check independent approval, only needs a reviewer's approval.


view run

@Eskalifer1

Copy link
Copy Markdown
Contributor

@MelvinBot please set the PR body to the content in the details section below

Details

Explanation of Change

When a workspace member opens the Per diem tab and the workspace has no per diem rates, the empty state said "This workspace…". Members can belong to several workspaces, so this change names the workspace instead.

  • workspace.perDiem.requestEmptyList.subtitle now takes the workspace name in every locale. The English copy follows the marketing-approved wording: "[workspaceName] doesn't have any per diem rates. Ask an admin to add some."
  • DynamicIOURequestStepDestination passes policy?.name to the member subtitle. The admin subtitle and the title stay the same.

Fixed Issues

$ #103898
PROPOSAL: #103898 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  1. As User A create a WS and enable Per diem without adding any per diem rate
  2. Invite a member(User B) (who doesn't have any WS enables Per diem)
  3. As User B, go FAB > Create expense > Per diem
  4. Make sure you see this description: [workspaceName] doesn't have any per diem rates. Ask an admin to add some.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Eskalifer1

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T11:17:05.363623Z ba2349c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…ace name is missing

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 74ca7bd0..a641545e 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -5104,8 +5104,8 @@ ${amount} für ${merchant} – ${date}`,
                 title: 'Noch keine Pauschalbeträge',
                 subtitle: (workspaceName?: string) =>
                     workspaceName
-                        ? `${workspaceName} hat keine Pauschalspesensätze. Bitten Sie eine Adminperson, einige hinzuzufügen.`
-                        : 'Dieser Workspace hat keine Pauschalspesensätze. Bitten Sie eine Adminperson, einige hinzuzufügen.',
+                        ? `${workspaceName} hat keine Tagegeldsätze. Bitten Sie eine:n Admin, welche hinzuzufügen.`
+                        : 'In diesem Workspace sind keine Tagegeldsätze vorhanden. Bitten Sie eine Administratorin oder einen Administrator, welche hinzuzufügen.',
                 adminSubtitle: 'Fügen Sie Pauschalen hinzu, um Ihre Ausgaben zu organisieren.',
             },
             importPerDiemRates: 'Tagespauschalen importieren',
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 103cf3c0..8728a1f8 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -5180,8 +5180,8 @@ ${amount} για ${merchant} - ${date}`,
                 title: 'Δεν υπάρχουν ακόμη ημερήσια επιδόματα',
                 subtitle: (workspaceName?: string) =>
                     workspaceName
-                        ? `Το ${workspaceName} δεν έχει ημερήσιες αποζημιώσεις. Ζητήστε από έναν διαχειριστή να προσθέσει μερικές.`
-                        : 'Αυτός ο χώρος εργασίας δεν έχει ημερήσιες αποζημιώσεις. Ζητήστε από έναν διαχειριστή να προσθέσει μερικές.',
+                        ? `Το ${workspaceName} δεν έχει καμία ημερήσια αποζημίωση. Ζητήστε από έναν διαχειριστή να προσθέσει μερικές.`
+                        : 'Αυτός ο χώρος εργασίας δεν έχει καμία ημερήσια αποζημίωση. Ζητήστε από έναν διαχειριστή να προσθέσει μερικές.',
                 adminSubtitle: 'Προσθέστε ημερήσια επιδόματα για να οργανώσετε τις δαπάνες σας.',
             },
         },
diff --git a/src/languages/es.ts b/src/languages/es.ts
index a5d4e038..e1ace683 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -5026,8 +5026,8 @@ ${amount} para ${merchant} - ${date}`,
                 title: 'Aún no hay tasas de Per diem',
                 subtitle: (workspaceName?: string) =>
                     workspaceName
-                        ? `${workspaceName} no tiene ninguna tasa de per diem. Pídele a un administrador que añada alguna.`
-                        : 'Este espacio de trabajo no tiene ninguna tasa de per diem. Pídele a un administrador que añada alguna.',
+                        ? `${workspaceName} no tiene ninguna tasa de per diem. Pide a una persona admin que añada algunas.`
+                        : 'Este espacio de trabajo no tiene ninguna tasa de per diem. Pídele a una persona administradora que añada alguna.',
                 adminSubtitle: 'Añade tasas de per diem para organizar tus gastos.',
             },
             importPerDiemRates: 'Importar tasas de per diem',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index c6a852af..d2c6115b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5111,7 +5111,7 @@ ${amount} pour ${merchant} - ${date}`,
                 subtitle: (workspaceName?: string) =>
                     workspaceName
                         ? `${workspaceName} n’a aucun taux de per diem. Demandez à un administrateur d’en ajouter.`
-                        : 'Cet espace de travail n’a aucun taux de per diem. Demandez à un administrateur d’en ajouter.',
+                        : 'Cet espace de travail n’a pas de taux de per diem. Demandez à un administrateur d’en ajouter.',
                 adminSubtitle: 'Ajoutez des taux de per diem pour organiser vos dépenses.',
             },
             importPerDiemRates: 'Importer des taux de per diem',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 98ea2bfe..073ec659 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -5073,7 +5073,7 @@ ${amount} per ${merchant} - ${date}`,
                 subtitle: (workspaceName?: string) =>
                     workspaceName
                         ? `${workspaceName} non ha nessuna tariffa di diaria. Chiedi a un amministratore di aggiungerne.`
-                        : 'Questo spazio di lavoro non ha nessuna tariffa di diaria. Chiedi a un amministratore di aggiungerne.',
+                        : 'Questo spazio di lavoro non ha tariffe di diaria. Chiedi a un admin di aggiungerne.',
                 adminSubtitle: 'Aggiungi le tariffe giornaliere per organizzare le tue spese.',
             },
             importPerDiemRates: 'Importa tariffe di diaria',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 212c24f6..26415781 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -5073,7 +5073,7 @@ ${amount} voor ${merchant} - ${date}`,
                 subtitle: (workspaceName?: string) =>
                     workspaceName
                         ? `${workspaceName} heeft geen dagvergoedingen. Vraag een beheerder om er een paar toe te voegen.`
-                        : 'Deze workspace heeft geen dagvergoedingen. Vraag een beheerder om er een paar toe te voegen.',
+                        : 'Deze workspace heeft geen dagvergoedingen. Vraag een admin om er een paar toe te voegen.',
                 adminSubtitle: 'Voeg dagvergoedingen toe om je uitgaven te organiseren.',
             },
             importPerDiemRates: 'Daggeldtarieven importeren',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index b5ffe2b9..23ea8f57 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -5104,8 +5104,8 @@ ${amount} dla ${merchant} - ${date}`,
                 title: 'Nie ma jeszcze stawek diet',
                 subtitle: (workspaceName?: string) =>
                     workspaceName
-                        ? `${workspaceName} nie ma żadnych stawek diet. Poproś administratora, żeby je dodał.`
-                        : 'Ten obszar roboczy nie ma żadnych stawek diet. Poproś administratora, żeby je dodał.',
+                        ? `${workspaceName} nie ma żadnych stawek diet. Poproś administratora, żeby dodał kilka.`
+                        : 'W tym obszarze roboczym nie ma żadnych stawek ryczałtowych. Poproś administratora o dodanie kilku.',
                 adminSubtitle: 'Dodaj stawki diet, żeby uporządkować swoje wydatki.',
             },
             importPerDiemRates: 'Zaimportuj stawki diet',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 57e55a7a..3a45c032 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -5064,8 +5064,8 @@ ${amount} para ${merchant} - ${date}`,
                 title: 'Ainda não há diárias',
                 subtitle: (workspaceName?: string) =>
                     workspaceName
-                        ? `${workspaceName} não tem nenhuma taxa de diária. Peça para um administrador adicionar algumas.`
-                        : 'Este espaço de trabalho não tem nenhuma taxa de diária. Peça para um administrador adicionar algumas.',
+                        ? `${workspaceName} não tem nenhuma diária configurada. Peça para um administrador adicionar algumas.`
+                        : 'Este workspace não tem nenhuma diária cadastrada. Peça para um administrador adicionar algumas.',
                 adminSubtitle: 'Adicione diárias para organizar seus gastos.',
             },
             importPerDiemRates: 'Importar tarifas de diária',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ebf5d993..1fd38744 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4919,7 +4919,8 @@ ${amount},商户:${merchant} - 日期:${date}`,
             },
             requestEmptyList: {
                 title: '尚未设置每日津贴费率',
-                subtitle: (workspaceName?: string) => (workspaceName ? `${workspaceName} 没有任何日津贴标准。请联系管理员添加一些。` : '此工作区没有任何日津贴标准。请联系管理员添加一些。'),
+                subtitle: (workspaceName?: string) =>
+                    workspaceName ? `${workspaceName} 尚未设置任何每日津贴标准。请联系管理员添加。` : '此工作区尚未设置任何每日补贴标准。请联系管理员添加。',
                 adminSubtitle: '添加每日津贴标准,以整理您的支出。',
             },
             importPerDiemRates: '导入每日津贴费率',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9e5bb02f0d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing Oxfmt check. The ternary in DynamicIOURequestStepDestination.tsx wasn't formatted the way oxfmt expects. I ran npm run fmt and pushed the result in 9e22880. The change is formatting only.

typecheck now passes: the earlier LinkTest.ts error was fixed on main and came in with the merge. The remaining failures are Check independent approval and PR Reviewer Checklist. Both clear once a reviewer approves and completes the checklist.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I updated the PR body with the content from your comment. I left out the outer <details> wrapper, so the sections show normally.


view run

Comment thread src/languages/zh-hans.ts Outdated
requestEmptyList: {title: '尚未设置每日津贴费率', subtitle: '此工作区尚未设置任何每日津贴费率,请联系管理员添加。', adminSubtitle: '添加每日津贴标准,以整理您的支出。'},
requestEmptyList: {
title: '尚未设置每日津贴费率',
subtitle: (workspaceName?: string) => (workspaceName ? `${workspaceName} 没有任何日津贴标准。请联系管理员添加一些。` : '此工作区没有任何日津贴标准。请联系管理员添加一些。'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot The Chinese subtitle says "日津贴标准" in both branches, while the rest of the per diem copy (and the previous string) uses "每日津贴". The "每" looks dropped, so the term is inconsistent and reads as a typo.

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot
MelvinBot marked this pull request as ready for review October 14, 2026 11:13
@MelvinBot
MelvinBot requested a review from a team as a code owner October 14, 2026 11:13
@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and joekaufmanexpensify and removed request for a team October 14, 2026 11:13
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 This PR is now marked as ready for review.

Note: the Tests and QA Steps sections still have the TODO placeholders. Please fill them in, along with the author checklist, before review.


view run

@melvin-bot

melvin-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team October 14, 2026 11:13

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

While working on PR i have found bug, already reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1791976716321309

@melvin-bot
melvin-bot Bot requested a review from neil-marcellini October 14, 2026 11:22
@Eskalifer1

Copy link
Copy Markdown
Contributor

@MelvinBot merge main

…ateWorkspaceName

Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team as a code owner October 14, 2026 13:24
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Merged main into this branch and pushed it (31ccc4c). There were no conflicts.

The merge brought in 25 commits from main. None of them change the files in this PR (the src/languages/*.ts files and DynamicIOURequestStepDestination.tsx).


view run

@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and removed request for a team October 14, 2026 13:24
@melvin-bot

melvin-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. I will clean up the PR description for you slightly, since I know sometimes it's hard to edit it with Melvin.

@neil-marcellini

Copy link
Copy Markdown
Contributor

(Neil's AI agent)

The failing test (job 7) check isn't caused by this PR. IOURequestStepConfirmationPageTest is flaky.

Re-running the job should clear it.

@neil-marcellini
neil-marcellini merged commit 15c6bba into main Oct 14, 2026
52 of 54 checks passed
@neil-marcellini
neil-marcellini deleted the claude-perDiemEmptyStateWorkspaceName branch October 14, 2026 14:20
@github-actions

Copy link
Copy Markdown
Contributor

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update is needed. This PR only changes the in-app empty-state message for members to name the workspace, and no help article quotes or describes that message.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update is needed. This PR only changes the in-app empty-state message for members to name the workspace, and no help article, including Per-Diem-Expenses.md, quotes or describes that message.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants