Repository navigation
Fix [Exploratory] Onboarding Task - Tap Organise spend & Somethng Else, Rotate phone 2 Landscpe can't scroll - #104069
Conversation
|
@codex please review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-16.at.00.39.19.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-10-16.at.19.08.21.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
@GCyganek In IOS, it doesn't work. Could you help check? Screen.Recording.2026-10-16.at.00.53.59.mov |
| </View> | ||
| )} | ||
|
|
||
| {isSomethingElseSelected && isInLandscapeMode && continueButton} |
There was a problem hiding this comment.
What do you think about using useShouldFooterBeInsideList() here, like TextInputFilterContent does? It only moves the button into the ScrollView when the keyboard is actually open in landscape, so the button stays pinned when there's room.
There was a problem hiding this comment.
I was thinking about that, but wanted to have the same behaviour as in BaseOnboardingAccounting, but I can just use useShouldFooterBeInsideList() for both
|
Should be fixed now, I also added changes to BaseOnboardingAccounting to make sure they work the same Screen.Recording.2026-10-16.at.10.47.09.movScreen.Recording.2026-10-16.at.10.51.06.movScreen.Recording.2026-10-16.at.10.51.33.movScreen.Recording.2026-10-16.at.10.46.51.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #103924 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.5.15-1 🚀
|
|
No help site update needed. This PR only fixes scrolling and the Continue button position on the onboarding screens in landscape mode. It doesn't change any feature, label, or step that a help article describes. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
|
@MelvinBot Please identify the PR that introduced the bug fixed by this PR. If possible, add a comment directly on the specific line of code that caused the issue, explaining the root cause |
|
The bug came from Add personal track goal onboarding screen, which first added this screen. I left an inline comment on the line that causes it. Root cause: That PR put the Continue button outside the Supporting evidence
|
Explanation of Change
Fixes the Personal Track Goal onboarding screen in landscape mode. The header is wrapped in
CollapsibleHeaderOnKeyboard, and in landscape the Continue button moves inside theScrollViewso it stays reachable above the keyboard. Selecting "Something else" scrolls to the end once the text input renders. Change is inBaseOnboardingPersonalTrackGoal.tsx.Fixed Issues
$ #103924
PROPOSAL: N/A
Tests
Precondition: Logged into the Expensify App.
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-15.at.12.05.40.mov
iOS: Native
Screen.Recording.2026-10-15.at.12.04.34.mov