Repository navigation
Conversation
|
@MelvinBot review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
ReviewThe code looks correct, and I found no blocking issues. The one gap is in the PR description: the Code:
Tests: The 5 cases cover the main paths. Jest's fake timers copy the browser's 2^31−1 overflow, which makes a single Gap to fix: The
All other CI checks pass. |
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Im not sure how to properly create such scenario in real life so I prepared JS script so its easy to paste into console (dev build). Script in Test section, with description. |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-19.at.15.34.50.movAndroid: mWeb ChromeScreen.Recording.2026-10-19.at.15.32.05.moviOS: HybridAppScreen.Recording.2026-10-19.at.15.38.08.moviOS: mWeb SafariCan't use console to test on mWeb safari MacOS: Chrome / SafariScreen.Recording.2026-10-19.at.15.30.22.mov |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.15-1 🚀
|
|
No help site update is needed. This bug fix makes the header button switch from Call scheduled back to its normal state once the call time passes, which is how users already expect it to work. No article sentence becomes incorrect. |
|
@LukasMod please share the QA steps. |
|
@kavimuru I’m not sure how you can QA a scheduled call on staging without access to the DevTools console. Generally, we wait until the scheduled time has passed and eventTime is reached so we can render component and hide this option. I tested it as described in the Tests section by injecting JS to make Onyx think there’s a scheduled call with fixed time, but I assume you should test it through the regular flow instead |
|
@LukasMod, could you please share clear QA steps then? |
|
I added QA Test 1 with simple injection code, its working fine on staging web |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
HeaderViewcomputedhasActiveScheduledCallwithisPast(eventTime)during render. React Compiler caches that onlatestScheduledCall, so after the call time the header kept showing "Call scheduled" until the call data or the report changed.useIsPastDate(date)hook. It arms one timeout atdateand re-renders once when it passes. No timer runs when there is no upcoming call, and nothing polls.setTimeoutfires immediately aboveCONST.LIMIT_TIMEOUT(about 24.8 days), so the hook waits inLIMIT_TIMEOUTsteps, then arms the exact timeout (same approach asUserStatusHandler).latestScheduledCall?.eventTimeand drops thedate-fnsimport. This fixes all consumers ofhasActiveScheduledCall: the onboarding help dropdown, bothFreeTrialbadges andEarlyDiscountBanner.Fixed Issues
$ #103608
PROPOSAL:
Tests
I did test with script that inject scheduled call.
Test 1: Button flips back at the call time
#adminsroom. Check if "Register for webinar" is visibleqaInjectCall()to override call for 5s (default)Test 2: Future and cancelled calls (regression)
#adminsroom. Check if "Register for webinar" is visibleqaInjectCall(3600)to override call for 1 hourqaCancelCall()to remove that overrideOffline tests
QA Steps
Test 1: Button flips back at the call time
example injection code:
Call scheduledright awayPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android.web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
I wasn't able to run console scripts in safari mobile web
MacOS: Chrome / Safari
web.mov