Skip to content

Fix stale scheduled call button in header - #104073

Merged
Julesssss merged 2 commits into
Expensify:mainfrom
callstack-internal:LukasMod/fix/stale-scheduled-call-header
Oct 19, 2026
Merged

Julesssss merged 2 commits into
Expensify:mainfrom
callstack-internal:LukasMod/fix/stale-scheduled-call-header

Conversation

@LukasMod

@LukasMod LukasMod commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • HeaderView computed hasActiveScheduledCall with isPast(eventTime) during render. React Compiler caches that on latestScheduledCall, so after the call time the header kept showing "Call scheduled" until the call data or the report changed.
  • fix: new useIsPastDate(date) hook. It arms one timeout at date and re-renders once when it passes. No timer runs when there is no upcoming call, and nothing polls.
  • Long delays: setTimeout fires immediately above CONST.LIMIT_TIMEOUT (about 24.8 days), so the hook waits in LIMIT_TIMEOUT steps, then arms the exact timeout (same approach as UserStatusHandler).
  • HeaderView: uses the hook for latestScheduledCall?.eventTime and drops the date-fns import. This fixes all consumers of hasActiveScheduledCall: the onboarding help dropdown, both FreeTrial badges and EarlyDiscountBanner.
  • Follow-up based on Reduce HeaderView re-rendering on every thread message #103604 (comment)

Fixed Issues

$ #103608
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

I did test with script that inject scheduled call.

  • create an account with company size 1-4
  • check your reportID for admin room
  • in the console, run the injection script
// QA helpers for the stale "Call scheduled" header fix (useIsPastDate). Platform agnostic: only uses Onyx, no DOM.
// Works in any NON-production build console where window.Onyx exists: web devtools, or React Native DevTools on iOS / Android.
//
// Prerequisite: company size 1-4 (nvp_introSelected.companySize === '1-4'), so the header button is deterministic:
//   - no active call: plain "Register for webinar" button (1-4 disables guide booking, leaving the webinar as the only option)
//   - active call:    "Call scheduled" dropdown
// Set REPORT_ID below to the workspace #admins room's reportID, open that room, then paste this file.
// Do not reload the app during a test: server data overwrites the injected value.
//
//   qaInjectCall()        Test 1: call 5s ahead, button must flip back on its own at the call time
//   qaInjectCall(3600)    Test 2a: call 1h ahead, button must read "Call scheduled"
//   qaCancelCall()        Test 2b: same call cancelled, button must read "Register for webinar"
//
// Injected calls stay local (no API call). After both tests the fake call is past or cancelled, so no cleanup is needed.
// Always finish Test 2 with qaCancelCall: a fake future call would make Reschedule / Cancel send its fake eventURI to the API.

(() => {
    // Set this to the #admins room's reportID before pasting (kept inside the function so pasting again does not redeclare it)
    const REPORT_ID = '';

    const Onyx = globalThis.Onyx;
    if (!Onyx?.get) {
        console.log('[QA] window.Onyx is missing: use a non-production build');
        return;
    }
    if (!REPORT_ID) {
        console.log('[QA] set REPORT_ID at the top of the script to the #admins reportID, then paste it again');
        return;
    }

    const pad = (n) => String(n).padStart(2, '0');

    // Same "YYYY-MM-DD HH:MM:SS" local-time format the backend uses for CalendlyCall.eventTime
    const formatEventTime = (date) => `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())} ${pad(date.getHours())}:${pad(date.getMinutes())}:${pad(date.getSeconds())}`;

    const nvpKey = `reportNameValuePairs_${REPORT_ID}`;
    let lastInjected;
    let callTimeTimer;

    const checkPrerequisite = () =>
        Onyx.get('nvp_introSelected').then((introSelected) => {
            if (introSelected?.companySize !== '1-4') {
                console.log(`[QA] WARNING: companySize is ${introSelected?.companySize}, expected 1-4. Labels may differ. Fix with: Onyx.merge('nvp_introSelected', {companySize: '1-4'})`);
            }
        });

    const writeCall = (call) => Onyx.merge(nvpKey, {calendlyCalls: [call]});

    globalThis.qaInjectCall = async (secondsAhead = 5) => {
        await checkPrerequisite();

        const callTime = new Date(Date.now() + secondsAhead * 1000);
        const call = {status: 'created', host: 1, eventTime: formatEventTime(callTime), eventURI: 'https://api.calendly.com/scheduled_events/qa-test', inserted: formatEventTime(new Date())};
        lastInjected = call;
        await writeCall(call);
        console.log(`[QA] injected call at ${call.eventTime}. Button should read "Call scheduled" now.`);

        // Marks the call time in the console so you can compare it with when the button flips. Do not touch the app meanwhile.
        clearTimeout(callTimeTimer);
        callTimeTimer = setTimeout(
            () => console.log(`[QA] call time reached (${call.eventTime}). Within about a second the button should read "Register for webinar" without any other action. Still "Call scheduled" = bug.`),
            Math.max(callTime.getTime() - Date.now(), 0),
        );
    };

    globalThis.qaCancelCall = async () => {
        if (!lastInjected) {
            console.log('[QA] no injected call yet, run qaInjectCall(3600) first');
            return;
        }
        clearTimeout(callTimeTimer);
        await writeCall({...lastInjected, status: 'cancelled'});
        console.log('[QA] call cancelled. Button should read "Register for webinar" now.');
    };

    console.log(`[QA] helpers loaded for report ${REPORT_ID}: qaInjectCall(secondsAhead = 5), qaCancelCall()`);
})();

Test 1: Button flips back at the call time

  1. Open the #admins room. Check if "Register for webinar" is visible
  2. Call qaInjectCall() to override call for 5s (default)
  3. Confirm the button reads Call scheduled right away
  4. Without sending a message or switching reports, wait past the call time
  5. Confirm within about a second the button shows previous value

Test 2: Future and cancelled calls (regression)

  1. Open the #admins room. Check if "Register for webinar" is visible
  2. Call qaInjectCall(3600) to override call for 1 hour
  3. Confirm the button reads Call scheduled right away and is pressable
  4. Calll qaCancelCall() to remove that override
  5. Confirm within about a second the button shows previous value

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

Test 1: Button flips back at the call time

  1. Open the #admins room. Check if "Register for webinar" is visible in header. You may need to select 1-4 company size in onboarding.
  2. Open developer tools console and type code below to mock scheduled call.
  • replace 6421319283656102 report ID with your admin report id from url
  • replace eventTime with date in next 2 min

example injection code:

Onyx.merge(`reportNameValuePairs_6421319283656102`, {calendlyCalls: [{status: 'created', host: 1, eventTime: '2026-10-21 11:05:00', eventURI: '', inserted: '2026-10-21 18:00:00'}]});
  1. Confirm the button reads Call scheduled right away
  2. Without sending a message or switching reports, wait past the call time (those 2 min)
  3. Confirm the button automatically flips back after that time without page refreshing

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mov
Android: mWeb Chrome
android.web.mov
iOS: Native
ios.mov
iOS: mWeb Safari

I wasn't able to run console scripts in safari mobile web

MacOS: Chrome / Safari
web.mov

@LukasMod

Copy link
Copy Markdown
Contributor Author

@MelvinBot review

@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/inbox/HeaderView.tsx 94.27% <100.00%> (+0.02%) ⬆️
src/hooks/useIsPastDate.ts 94.11% <94.11%> (ø)
... and 7 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor

Review

The code looks correct, and I found no blocking issues. The one gap is in the PR description: the Tests and QA Steps sections have no real steps yet.

Code: src/hooks/useIsPastDate.ts does what the PR says:

  • passedDate === date drives the flip, so it still works even though React Compiler memoizes isPast(date).
  • Because the passed state is tied to one date, a rescheduled call resets to "upcoming."
  • Delays longer than LIMIT_TIMEOUT wait in steps and recheck Date.now() each time, so time spent asleep or in the background is handled.
  • The cleanup clears the timer when the date changes or the component unmounts, and an invalid date (NaN) arms no timer.

Tests: The 5 cases cover the main paths. Jest's fake timers copy the browser's 2^31−1 overflow, which makes a single setTimeout fire after 1 ms. So the long-delay test would catch a regression.

Gap to fix: The Tests and QA Steps sections contain only the console-error checkbox and the // TODO, which is why checklist fails. Suggested steps:

  1. Open the onboarding chat for an account with a call scheduled a few minutes ahead.
  2. Verify the header button shows "Call scheduled."
  3. Stay on the page without navigating until the call time passes.
  4. Verify the button changes back to the default help button and the trial/discount badges update.

All other CI checks pass. branch-perf-tests is still pending.


view run

@LukasMod
LukasMod marked this pull request as ready for review October 16, 2026 10:09
@LukasMod
LukasMod requested review from a team as code owners October 16, 2026 10:09
@melvin-bot
melvin-bot Bot requested review from nkdengineer and removed request for a team October 16, 2026 10:09
@melvin-bot

melvin-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 16, 2026 10:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T10:24:57.189607Z 05812e3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LukasMod

Copy link
Copy Markdown
Contributor Author

Im not sure how to properly create such scenario in real life so I prepared JS script so its easy to paste into console (dev build). Script in Test section, with description.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@nkdengineer

nkdengineer commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-10-19.at.15.34.50.mov
Android: mWeb Chrome
Screen.Recording.2026-10-19.at.15.32.05.mov
iOS: HybridApp
Screen.Recording.2026-10-19.at.15.38.08.mov
iOS: mWeb Safari

Can't use console to test on mWeb safari

MacOS: Chrome / Safari
Screen.Recording.2026-10-19.at.15.30.22.mov

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested review from Julesssss and cristipaval October 19, 2026 08:41
@Julesssss
Julesssss merged commit e849d00 into Expensify:main Oct 19, 2026
45 of 48 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.5.15-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This bug fix makes the header button switch from Call scheduled back to its normal state once the call time passes, which is how users already expect it to work. No article sentence becomes incorrect.


view run

@kavimuru

Copy link
Copy Markdown

@LukasMod please share the QA steps.

@LukasMod

Copy link
Copy Markdown
Contributor Author

@kavimuru I’m not sure how you can QA a scheduled call on staging without access to the DevTools console. Generally, we wait until the scheduled time has passed and eventTime is reached so we can render component and hide this option. I tested it as described in the Tests section by injecting JS to make Onyx think there’s a scheduled call with fixed time, but I assume you should test it through the regular flow instead

@IuliiaHerets

Copy link
Copy Markdown

@LukasMod, could you please share clear QA steps then?

@LukasMod

Copy link
Copy Markdown
Contributor Author

I added QA Test 1 with simple injection code, its working fine on staging web

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants