Skip to content

Fix Android crash after toggling the Insights beta - #104327

Closed
MelvinBot wants to merge 4 commits into
mainfrom
claude-fixInsightsBetaToggleCrash
Closed

MelvinBot wants to merge 4 commits into
mainfrom
claude-fixInsightsBetaToggleCrash

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

The native tab bar shows five of the six tabs, and the Insights beta decides which tab gets no bar item: Account with the beta, Insights without it. The hidden-tab-items patch renders no Tabs.Screen for that tab. So turning the beta on or off removes one native tab from the Tabs.Host and inserts another.

Android cannot remove a native tab in place (TabsHostViewManager does not override getChildAt/getChildCount, as documented for the stable-native-tab-identity patch). The host kept a stale tab, and its selected tab pointed at it. The app crashed when the host was shown again after the user left Beta overrides.

This PR adds @react-navigation+bottom-tabs+7.19.2+005+remount-native-tabs-host-on-hidden-change.patch. It keys Tabs.Host by the hidden route names instead of the fixed "native-tabs-host". When the set of hidden routes changes, React replaces the whole host with a fresh one that has the right tabs, so no tab is removed in place. Route re-keys (markFocusedTabRouteForRemount) don't change the route names, so they don't remount the host. The beta rarely changes, so remounting the tab contents then is acceptable.

A unit test in tests/unit/NativeBottomTabViewTest.tsx checks that the host remounts when a different route is hidden, and doesn't remount when only a route key changes. The new test fails without the patch.

Fixed Issues

$ #104280
PROPOSAL: #104280 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

AI Tests

Run locally by MelvinBot:

  • npm test -- tests/unit/NativeBottomTabViewTest.tsx: 3/3 passed. The new test fails without the patch, as expected.
  • git apply of patch 005 on top of patches 001–004: applies and reverses cleanly. The base blob hash matches patch 004's result.
  • ./scripts/validatePatches.sh: passed.
  • npm run typecheck: passed.
  • npm run lint-changed: passed.
  • npm run spell-changed: passed.
  • Not run: the oxfmt format check and patch-package apply (both need approval in this environment), and the full Jest suite. CI covers these.
  • Not run: a device test. The fix only affects the native Android/iOS tab bar, so web can't test it. It needs testing on an Android device with the issue's steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Turning the Insights beta on or off swaps which tab has no native bar item.
Android cannot remove a native tab in place, so the host kept a stale tab
and crashed when shown again. Key the host by the hidden route names so it
is replaced with a fresh one instead.

Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team October 19, 2026 04:43
Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixInsightsBetaToggleCrash
git checkout -b claude-fixInsightsBetaToggleCrash upstream/claude-fixInsightsBetaToggleCrash
git push -u origin claude-fixInsightsBetaToggleCrash

Then you can close this PR and open a new one from your fork.

@daledah

daledah commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please merge main

…aToggleCrash

Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I merged main into this branch and pushed it as b185748. The merge had no conflicts.


view run

@daledah

daledah commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot please merge main and open this PR

…aToggleCrash

Co-authored-by: daledah <daledah@users.noreply.github.com>
@MelvinBot
MelvinBot marked this pull request as ready for review October 23, 2026 02:47
@melvin-bot
melvin-bot Bot requested review from daledah and removed request for a team October 23, 2026 02:47
@melvin-bot

melvin-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done. I merged the latest main into this branch with no conflicts and pushed it as commit 67fd42e. The PR is now marked ready for review.


view run

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T02:51:17.399174Z 67fd42e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67fd42e70f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

const nativeSelectedScreenKey = state.routes.find(route => route.key === nativeSelectedRouteKey)?.name ?? nativeSelectedRouteKey;
+ // Android cannot remove a native tab in place, so a change in which routes are hidden would leave the host with a
+ // stale tab and crash it. Keyed by the hidden route names, the host is remounted with the new set of tabs instead.
+ const nativeTabsHostKey = `native-tabs-host-${state.routes.filter(isRouteHidden).map(route => route.name).join(',')}`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Consolidate the duplicate native-host remount

When the hidden route changes in production, NativeTabLayout.tsx already derives the same route-name key at lines 22–25 and applies it to the View containing children at lines 31–35, so NativeBottomTabView and its Tabs.Host are unmounted before this new host key can be reconciled against its previous value. The added test misses this because it renders NativeBottomTabView directly without the production layout. Remove either the existing layout-level workaround or this patch; as written, the commit adds a dependency patch that changes no production behavior and leaves two implementations to maintain.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot please check this comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex is right: this patch is now redundant. main already has the same fix at the layout level, so the patch changes nothing in production.

[Liquid Glass Follow Up] Fix native tab bar issues when the Insights beta is on merged on Oct 21, after this PR was opened. It keys the View around children by the names of routes with tabBarItemHidden (NativeTabLayout.tsx:22-35). The patch's isRouteHidden reads the same tabBarItemHidden option and builds the same name list. So when the Insights beta changes, the layout remounts NativeBottomTabView and its Tabs.Host before the new host key is ever compared. The new unit test misses this because it renders NativeBottomTabView without NativeTabLayout.

I recommend you close this PR rather than keep two copies of the fix. Before you do, confirm on Android that the crash in [$175] Android - Troubleshoot - App crashes after "Insigths Page" beta is disabled. no longer happens on main. That merged PR doesn't list this issue, and I can't test Android in this run.

If the crash still happens, reply with @MelvinBot and I'll investigate. If you'd rather keep the PR, I can remove the layout-level key instead.


view run

@daledah

daledah commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Looks like this issue was handled in this PR, so I’m closing it.

@daledah daledah closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants