Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
JakubKorytko
left a comment
There was a problem hiding this comment.
Nothing blocking, a few small ones below
|
@MelvinBot review |
ReviewI found no correctness bugs. The tests assert real behavior and I found nothing flaky. Before merging, close one coverage gap and fix a few PR description claims. 1. Coverage gap: no test presses the pad anymore. The removed 2. The PR description claims checks the tests don't make:
Nits and what I checked
|
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.20-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.20-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Following the consolidation of
NumericInputwith the full-screen layout architecture andBigNumberPad(#102140), this PR introduces a dedicated UI test suite validating responsiveness and layout behavior across device form factors, screen orientations, and input capabilities (phones, tablets, and non-touch devices).Key testing coverage introduced:
NumericInputLayoutTest.tsx):useIsInLandscapeMode).NumericInputLayoutTabletTest.tsx):NumericInputLayoutWithoutTouchScreenTest.tsx):NumericInputLayoutTestUtils.tsx,NumericBigNumberPadTest.tsx):NumericInputLayoutTestUtils.tsx.NumericBigNumberPadTest.tsxnow covered by the dedicated layout suite.Fixed Issues
$ #98171
PROPOSAL: #97970
Tests
N/A - Test suite additions only. Automated tests are executed via CI, and can be run locally with:
npm run test -- tests/ui/NumericInputLayout* tests/ui/NumericBigNumberPadTest.tsxOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.