Repository navigation
Conversation
…-ReactModalHostView-updateSystemAppearance-dialog-must-exist
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
|
@TaduJR details.md needs to be updated. Other crash fixes in that file include their Sentry ID to ensure the intent is clear during future upgrades. Without this context, anyone regenerating patch 019 for React Native 0.87 might mistake the guard for an incidental null check when resolving conflicts and accidentally drop it, causing the crash to silently reappear |
…-ReactModalHostView-updateSystemAppearance-dialog-must-exist
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-23.at.20.02.40.movAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.21-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
On Android, the React Native patch
react-native+0.86.0+019+fix-modal-transparent-navigation-bar.patchupdates a modal's status and navigation bar icons a second time, shortly after the modal appears, so they match the screen behind it. If the modal closes after it appears but before that second update runs, the modal no longer has a dialog and the app crashes withdialog must exist when we call updateProperties. This happens when a screen is navigated away from right as a modal on it opens, for example when Date is tapped right after Category on the Create expense page.The second update now runs only if the modal still has the same dialog it was scheduled for, and is skipped otherwise. Two existing comments in the patch were also reworded, with no change in behavior.
Fixed Issues
$ #103778
PROPOSAL:
Tests
Precondition: Android app, signed in, with a workspace that has categories turned on.
A. The app does not crash when the date picker opens while leaving the page
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-10-22.at.10.51.15.AM.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari