Repository navigation
[Liquid Glass Follow Up] Native tab bar switches theme together with the app - #104733
Conversation
…head of its debounce
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
All good on my end
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-26.at.10.00.22.movAndroid: mWeb ChromeScreen.Recording.2026-10-26.at.09.58.54.moviOS: HybridAppScreen.Recording.2026-10-26.at.09.57.41.moviOS: mWeb SafariScreen.Recording.2026-10-26.at.09.51.30.movMacOS: Chrome / SafariScreen.Recording.2026-10-26.at.09.49.43.mov |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.21-0 🚀
|
|
No help site update is needed. This bug fix makes the native tab bar switch theme at the same time as the rest of the app, which users already expect, and it doesn't make any sentence in an existing article wrong. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.23-0 🚀
|
|
No help site update is needed. This bug fix makes the native tab bar switch theme at the same time as the rest of the app, which users already expect, and it doesn't make any sentence in an existing article wrong. |
|
Hi @sumo-slonik. QA team failed this PR with an original issue, when switching to dark mode, the bottom bar briefly flashes in light mode 1793058078993.ScreenRecording_10-26-2026_18-37-41_1.mp41793058907668.ScreenRecording_10-26-2026_18-52-52_1.mp4 |
|
I suppose it's okay, and it's just animation 😁 |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The app theme switches after a debounce in
ThemeProvider, but the navigation theme was built from the raw theme preference, and the native tab bar takes its color scheme from the navigation theme. So the bar switched theme before the rest of the app. The navigation theme now follows the app theme's color scheme, so both switch together.Fixed Issues
$ #104201
PROPOSAL: N/A
Tests
Offline tests
N/A: the change only moves when the navigation theme switches. It sends no requests and reads no data that depends on the network state.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
No visible change: the web tab bar is not native and does not read its colors from the navigation theme.
iOS: Native
iOS: mWeb Safari
No visible change: the web tab bar is not native and does not read its colors from the navigation theme.
MacOS: Chrome / Safari
No visible change: the web tab bar is not native and does not read its colors from the navigation theme.