Repository navigation
101425: Native share - Android - No sharing flow/app freezes when share image signed out - #105299
abbasifaizan70 wants to merge 16 commits into
Conversation
…re image signed out
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@MelvinBot review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 732c4dde37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@jayeshmangwani Can you review again? |
garrettmknight
left a comment
There was a problem hiding this comment.
Flow looks good from a product perspective.
Sorry for the delay. I was OOO for a few days, but I'm testing this PR again today. |
|
@abbasifaizan70 I tried testing this on iOS 27.2, but the fix doesn't seem to work for me. Screen.Recording.2026-11-15.at.7.20.48.AM.mov |
Screen.Recording.iPhone.17.Pro.Max.18-11-2026.at.4.33.46.AM.mp4@jayeshmangwani I updated with latest main and after tested it working totally fine. Can you check again? Thanks |
# Conflicts: # src/libs/Navigation/NavigationRoot.tsx
|
@jayeshmangwani all review comments are addressed and pushed:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bb2afb55f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return; | ||
| } | ||
| attempts++; | ||
| pushShareFlow(); |
There was a problem hiding this comment.
Wait for the welcome modal's exit navigation before retrying
When a native share is parked behind the migrated-user welcome modal, the dismissal state event can precede transitionStart, so this retry opens and consumes the share before the modal's exit navigation. Fresh evidence beyond the earlier consumption issue is src/components/MigratedUserWelcomeModal.tsx:62–66, where handleClose schedules Navigation.navigate(spendRoute) in goBack's afterTransition. That later navigation pushes TabNavigator above the share (src/libs/Navigation/helpers/linkTo/index.ts:240–244), leaving the user on Spend with no pending intent to reopen. Retry after the welcome modal's landing navigation, rather than as soon as the modal disappears.
Useful? React with 👍 / 👎.
| if (isNativeShareLink(route) && shouldParkNativeShare(isAuthenticated)) { | ||
| setPendingNativeShare(); | ||
| return; |
There was a problem hiding this comment.
Preserve the anonymous-session sign-in gate for parked shares
If the user has an anonymous public-room session created during this app run and shares while OpenApp is still loading, this early return captures the link instead of reaching the anonymous-route check at src/libs/actions/Link.ts:599–601. After loading, useOnboardingFlowRouter replays it through openPendingNativeShare, which never checks the session type, even though canAnonymousUserAccessRoute('share/root') is false. The result is the Share composer under an anonymous account, with no real sign-in prompt, rather than the existing sign-out/sign-in flow. Preserve that access gate before parking or replaying the intent.
Useful? React with 👍 / 👎.
Explanation of Change
A share received while signed out is now parked in memory instead of being replayed through the report deep-link path, which dropped it (or set the onboarding error) for a new account.
linkingConfig.filterstops React Navigation from mountingshare/rootas launch state while signed out, so onboarding no longer evicts the share modal.useOnboardingFlowRouteropens the parked share when onboarding isn’t needed, and defers it when onboarding starts; the onboarding exits then open it on top of the landing screen.Fixed Issues
$ #101425
PROPOSAL: #101425 (comment)
Tests
Scenario 1:
Scenario 2:
Offline tests
same as tests.
QA Steps
same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20261103_003728_New.Expensify.Dev.mp4
Screen_Recording_20261103_003554_New.Expensify.Dev.1.mp4
Android: mWeb Chrome
Not applicable.
iOS: Native
Screen.Recording.iPhone.17.Pro.Max.03-11-2026.at.12.57.55.AM.mp4
iOS: mWeb Safari
Not applicable.
MacOS: Chrome / Safari
Not applicable.