Repository navigation
Scroll New rule to a refused rule so the keyboard doesn't cover it - #105457
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-30.at.22.07.55.movAndroid: mWeb ChromeScreen.Recording.2026-10-30.at.21.57.19.moviOS: HybridAppScreen.Recording.2026-11-04.at.14.58.25.moviOS: mWeb SafariScreen.Recording.2026-10-30.at.22.02.28.movMacOS: Chrome / SafariScreen.Recording.2026-10-30.at.21.55.52.mov |
|
@yuwenmemon it seems you haven't completed "PR Author Checklist" |
trjExpensify
left a comment
There was a problem hiding this comment.
Would be great to have some videos included! :)
|
@trjExpensify, you can check my recordings in the meantime. I still need some time for iOS build, but it should work the same as Android. |
|
@hoangzinh I can create an ad hoc build if that's easier |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
It's reproducible in the current main branch as well. @yuwenmemon, will you fix this bug in this PR or in another follow-up PR? |
|
Yeah we can do so as a follow-up |
|
Issue created (with PR) @hoangzinh, could you help me test the Android ad hoc build there? |
sure, @yuwenmemon |
@trjExpensify, given that the new issue you found above will be fixed in another issue. Can you help with another review round for the original issue that we're trying to fix in this PR? TY |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.5.32-0 🚀
|
|
No FullStory changes needed. This PR only fixes scrolling so the keyboard no longer covers existing rule-refusal messages and buttons. |
|
No help site update needed. This PR only fixes scrolling to keep existing refusal messages and buttons visible above the keyboard; it does not change a workflow or make existing instructions incorrect. |
|
This PR failing because of the issue #106059 |
I think it's another issue 👀. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀
|

Explanation of Change
When Concierge refuses a description on New rule, the reason, the suggested description and the Create anyway and Use suggestion buttons show below the describe box. On iOS and Android the keyboard stays open after Next, so all of it sits under the keyboard until the admin scrolls.
The form now scrolls to its end when a refusal arrives. The scroll waits for the keyboard animation and stops at the end of the content, so the box stays in view above the refusal when it fits. The keyboard stays open, so the admin can still edit the description.
The rule editors' Describe modal uses the same form without a scroll view, so nothing changes there.
Fixed Issues
$ #105449
PROPOSAL: N/A
Tests
describeRulebeta on, open a Control workspace > Rules > Add rule on iOS or Android.Force a refusal against the dev VM
The VM's answer depends on its model and RuleBot vocabulary. Paste this in the console before step 2 to turn the next answer into a refusal:
Offline tests
N/A. Describing a rule needs a connection, so no refusal arrives offline.
QA Steps
Same as tests, on staging, where Concierge refuses the description in step 2.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari