Skip to content

Fix Not Here page when editing a split from the Date tab opened from Spend - #105749

Merged
neil-marcellini merged 1 commit into
mainfrom
claude-fixSplitDateTabNotHereFromSpend
Nov 4, 2026
Merged

neil-marcellini merged 1 commit into
mainfrom
claude-fixSplitDateTabNotHereFromSpend

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

When the split flow is opened from Spend > Expenses, clicking a split row on the Date tab navigates to /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>. Because date is the third path segment, the legacy '/*/*/date/*/*/*' redirect in OldRoutes.ts matched this URL and rewrote it to /r/edit/expense-date?..., which shows the "Hmm... it's not here" page.

This PR adds a more specific pass-through entry, '/*/*/date/split-expense/edit/*', that maps the URL back to itself. getMatchingNewRoute picks the longest matching pattern, so this entry wins over the legacy date redirects. Real legacy date URLs (for example, /edit/submit/date/123/456) still redirect as before. This follows the existing participants pass-through entry in the same file.

A unit test in tests/navigation/getMatchingNewRouteTest.ts covers the split edit URL with and without a query string.

Fixed Issues

$ #105152
PROPOSAL: #105152 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Spend > Expenses.
  5. Select the expense via checkbox.
  6. Click More > Split.
  7. Go to Date tab.
  8. Click on any split.
  9. Verify the split page opens (not the "Hmm... it's not here" page).
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI web test (MelvinBot): split edit page opens from the Date and Amount tabs
Date tab row Amount tab row
Split edit page reached from the Date tab Split edit page reached from the Amount tab

AI Tests

  • npm test -- tests/navigation/ — 74 suites, 842 tests passed (includes the new getMatchingNewRoute case).
  • npm run typecheck — passed.
  • npm run lint-changed — passed.
  • npm run spell-changed — no issues.
  • Web test on the dev build: from Spend > Expenses > More > Split, a split row on the Date tab and on the Amount tab both open the split edit page. No console errors.
  • Not run locally: formatter check (oxfmt), full npm test, and the Storybook smoke test.

… by legacy date redirects

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Android test steps verification results: ✅ pass

On standalone Android NewDot, this PR fixes the bug: tapping a split row on the Date tab of the split flow (from Spend > Expenses) now opens the split edit page instead of the "Hmm... it's not here" page. The Amount tab regression check also passed.
Split edit page opened from Amount tab row

Step Status
Create an expense in a workspace chat and confirm it appears in the chatManual expense (Test Merchant, $2,500.00, Materials, Nov 3) created in the workspace chat; it appeared in the chat.
Expense appears in workspace chat
✅
In Spend > Expenses, select the expense via its checkbox; the selection bar/More menu appearsSelection mode enabled with a checked checkbox and a "1 selected" bar (Expenses: 1, Total spend: $2,500.00).
Expense selected via checkbox in Spend > Expenses
✅
Tap More > Split; the split expense page opensThe actions menu listed Split; tapping it opened the split screen with Date, Percent, and Amount tabs.
More menu with Split option
Split expense page opened
✅
Switch to the Date tab; split rows are listedTitle changed to "Split by date" with two split rows of $1250.00 each.
Date tab showing split rows
✅
Tap a split row on the Date tab; the split edit page opens (not "Hmm... it's not here")Opened "Edit $1,250.00 for Test Merchant" with Description, Category, Date, Reimbursable, Report, Remove split, and Save. No Not Here page.
Split edit page opened from Date tab row
✅
Regression: go back, switch to the Amount tab, tap a split row; the split edit page opens normallyOpened the same "Edit $1,250.00 for Test Merchant" split edit page.
Split edit page opened from Amount tab row
✅

view run · view recording

@situchan

situchan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@codex review

@situchan

situchan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T12:11:54.318355Z 277e8e0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 277e8e06dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@MelvinBot

MelvinBot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ✅ pass

Clicking a split row on the Date tab of the split flow (opened from Spend > Expenses) now opens the split edit page, not the "Hmm... it's not here" page. The Amount tab regression check also passed.
Split edit page opened from an Amount tab row

Step Status
In a workspace chat, create an expense and confirm it appears in the chatCreated a manual $25.00 expense for Melvin Test Merchant. It opened inside the workspace report chat with Amount, Merchant, and Date fields.
Expense open in its workspace report chat
✅
Go to Spend > Expenses and select the expense via its checkbox; the selection bar/More menu appearsChecking the row showed a toolbar with Export, Hold, Merge, More, and Clear selection, plus "Expenses: 1, Total spend: $25.00".
Selection bar after checking the expense row
✅
Click More > Split; the split expense page opensThe More menu listed Split. Clicking it opened the Split page with Amount, Percent, and Date tabs and two $12.50 rows.
Split page with Amount, Percent, and Date tabs
✅
Switch to the Date tab; split rows are listedThe heading changed to "Split by date" and listed both split rows.
Date tab listing split rows
✅
Click a split row on the Date tab; the split edit page opens (not "Hmm... it's not here")Opened "Edit $12.50 for Melvin Test Merchant" with Description, Category, Date, Remove split, and Save. No Not Here page.
Split edit page opened from a Date tab row
✅
Regression: go back, switch to the Amount tab, click a split row; the split edit page opens normallyOpened the same "Edit $12.50 for Melvin Test Merchant" page.
Split edit page opened from an Amount tab row
✅
No errors appear in the JS console during this flowNo error banners, overlays, or broken pages appeared. The test browser could not read the raw JS console, so this check is based on the visible UI only.
⚠️

view run · view recording

@situchan

situchan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot add QA steps (same as in the linked issue) and mark this PR ready for review

@MelvinBot

MelvinBot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ⚠️ partial

No regressions found. Split rows open the edit page from the Date and Percent tabs and from both entry points (Spend and the expense view). Split edits and full splits save, and normal date edits work. The tester could not reload the page or open a legacy URL directly, so those two checks did not run in the browser.
Normal expense date updated and saved

Step Status
Spend > Expenses > More > Split > Date tab > click a split row opens the split edit pageOpened "Edit $12.50 for Melvin Split Test Merchant" with Description, Category, Date, Reimbursable, Remove split, and Save.
Split edit page opened from Date tab row
✅
Reload the browser on the Date-tab split edit URL; the page still loadsNot run. The tester has no way to reload the browser. A reload sends the URL through the same matcher, and the PR's unit test checks that this URL passes through unchanged, with and without a query string (getMatchingNewRouteTest.ts:117-125).
⚠️
From the Date-tab split edit page, change the description and SaveReturned to "Split by date". Reopening the row showed the saved description "Split date-tab test".
Split by date list after saving description
✅
Percent tab: clicking a split row opens the split edit pageRows showed 50% each. Clicking one opened the same split edit page.
Split edit page opened from Percent tab row
✅
Split started from the expense view (not Spend): Date tab > click a row opens the split edit pageOpened a $40.00 expense from the workspace chat, used More > Split, then Date tab. Clicking a row opened "Edit $20.00 for Report View Split Test".
Split edit page opened from the expense view split flow
✅
Complete a split from the Spend flow; the split saves without errorsTwo $12.50 expenses appeared with an "Expense added" toast. Transaction_Split returned 200.
Two resulting expenses after completing the split
✅
Legacy redirect: opening /edit/submit/date/<transactionID>/<reportID> still goes to the expense date pageNot run. The tester could not open a URL directly or read a real transactionID. Existing unit tests still assert both legacy date redirects (getMatchingNewRouteTest.ts:653-654), and the PR reports the navigation suite passing.
⚠️
Edit the date of a normal (non-split) expense from the expense viewChanged the date to Nov 2 and saved. The expense showed 2026-11-02 and UpdateMoneyRequestDate returned 200.
Normal expense date updated and saved
✅

view run · view recording

@MelvinBot
MelvinBot marked this pull request as ready for review November 3, 2026 12:07
@MelvinBot
MelvinBot requested a review from a team as a code owner November 3, 2026 12:07
@melvin-bot
melvin-bot Bot requested a review from situchan November 3, 2026 12:07
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I added the QA steps and marked this PR ready for review.

The QA steps follow the linked issue, [$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend. They end with a check that the split page opens, not the "Hmm... it's not here" page.

The Tests section still has its TODO placeholder. Let me know if you want it filled in too.


view run

@melvin-bot
melvin-bot Bot removed the request for review from a team November 3, 2026 12:07
@melvin-bot

melvin-bot Bot commented Nov 3, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 3, 2026 12:07
@situchan

situchan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
test.mov

@melvin-bot
melvin-bot Bot requested a review from neil-marcellini November 3, 2026 12:08

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for product

@neil-marcellini neil-marcellini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks.

@neil-marcellini
neil-marcellini merged commit 5f6501f into main Nov 4, 2026
56 of 58 checks passed
@neil-marcellini
neil-marcellini deleted the claude-fixSplitDateTabNotHereFromSpend branch November 4, 2026 00:03
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 4, 2026
88 tasks done
@OSBotify

OSBotify commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No FullStory changes needed. This PR only fixes a redirect bug when opening an existing split expense edit screen from the Date tab.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

No help site update needed — this PR fixes navigation to an existing split expense edit screen, restoring expected behavior without changing the documented workflow.

@OSBotify

OSBotify commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants