Repository navigation
Fix Not Here page when editing a split from the Date tab opened from Spend - #105749
Conversation
… by legacy date redirects Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
@codex review |
|
@MelvinBot review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🤖 Web test steps verification results: ✅ pass Clicking a split row on the Date tab of the split flow (opened from Spend > Expenses) now opens the split edit page, not the "Hmm... it's not here" page. The Amount tab regression check also passed.
|
|
@MelvinBot add QA steps (same as in the linked issue) and mark this PR ready for review |
|
🤖 Web test steps verification results: No regressions found. Split rows open the edit page from the Date and Percent tabs and from both entry points (Spend and the expense view). Split edits and full splits save, and normal date edits work. The tester could not reload the page or open a legacy URL directly, so those two checks did not run in the browser.
|
|
I added the QA steps and marked this PR ready for review. The QA steps follow the linked issue, [$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend. They end with a check that the split page opens, not the "Hmm... it's not here" page. The |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.mp4iOS: mWeb SafariMacOS: Chrome / Safaritest.mov |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
good for product
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.32-0 🚀
|
|
No FullStory changes needed. This PR only fixes a redirect bug when opening an existing split expense edit screen from the Date tab. |
|
No help site update needed — this PR fixes navigation to an existing split expense edit screen, restoring expected behavior without changing the documented workflow. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀
|



















Explanation of Change
When the split flow is opened from Spend > Expenses, clicking a split row on the Date tab navigates to
/search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>. Becausedateis the third path segment, the legacy'/*/*/date/*/*/*'redirect inOldRoutes.tsmatched this URL and rewrote it to/r/edit/expense-date?..., which shows the "Hmm... it's not here" page.This PR adds a more specific pass-through entry,
'/*/*/date/split-expense/edit/*', that maps the URL back to itself.getMatchingNewRoutepicks the longest matching pattern, so this entry wins over the legacy date redirects. Real legacy date URLs (for example,/edit/submit/date/123/456) still redirect as before. This follows the existing participants pass-through entry in the same file.A unit test in
tests/navigation/getMatchingNewRouteTest.tscovers the split edit URL with and without a query string.Fixed Issues
$ #105152
PROPOSAL: #105152 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI web test (MelvinBot): split edit page opens from the Date and Amount tabs
AI Tests
npm test -- tests/navigation/— 74 suites, 842 tests passed (includes the newgetMatchingNewRoutecase).npm run typecheck— passed.npm run lint-changed— passed.npm run spell-changed— no issues.oxfmt), fullnpm test, and the Storybook smoke test.