Repository navigation
Fix floating labels after currency changes - #106152
Conversation
Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
I created this PR from an upstream branch because I don't have push access to To copy the branch to your fork: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-amountCurrencyLabel
git checkout -b claude-amountCurrencyLabel upstream/claude-amountCurrencyLabel
git push -u origin claude-amountCurrencyLabelYou can then close this draft and open a PR from your fork. |
|
🤖 Android test steps verification results: Verified on standalone Android NewDot: Amount’s two empty blurred labels float without AED-prefix overlap after Any currency → AED. The first bound returns inline after AED → Any currency; Purchase amount coverage and JS-console verification remain incomplete.
|
|
@MelvinBot the workflow is failing. |
|
The actionable failure is Oxfmt check: formatting changes are required in BaseTextInputLabelTest.tsx. Run The separate independent approval check requires human review. All other reported checks passed or were skipped, including Jest, Storybook, lint, and typecheck. |
|
@MelvinBot, your code shouldn't fail Oxfmt in the first place. Please write it correctly. |
Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
You’re right—I should have caught this before opening the PR, rather than asking you to fix it. Corrected and pushed 06601225. Only test-file line wrapping changed.
|
|
@MelvinBot mark this pr as ready for review. |
|
Marked Fix floating labels after currency changes as ready for review. |
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review this for accessibility issues |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-native.webmAndroid: mWeb Chromeandroid-web.webmiOS: HybridAppios-native.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safarimac-web.mov |
|
@MelvinBot the prefix is not announced by screen readers. prefix.webm |
|
🤖 Web test steps verification results: Verified on dev NewDot web: the empty Amount filter input excludes currency from its accessible name, while the separate currency button includes it. Actual screen-reader speech was not tested.
|
|
@MelvinBot, do you think the prefix should be announced by screen readers? If so, please fix it. |
Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
|
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Web test steps verification results: Verified the local fix in commit abc6cd27: currency-aware computed accessible names and numeric-value preservation passed for Amount and Purchase amount. Real screen-reader speech remains unverified; screenshots do not prove spoken output.
view run · no recording available |
|
|
|
MelvinBot doesn't provide QA steps, so I suggest the following:
|
|
Those QA steps look good to me, added to the OP |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR only fixes overlapping floating labels and missing currency context for screen readers in existing amount filters. |
|
No help site update needed—this PR fixes overlapping input labels and missing currency context for screen readers, restoring expected behavior without introducing a new workflow or making existing article instructions incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |













Explanation of Change
Keep empty, blurred input labels floated when a currency prefix, suffix, or forced-active setting is added after mount. This prevents labels from overlapping restored currency prefixes. Apply the same activation rule to web and native without changing autofill handling or ordinary empty-field behavior.
Add 10 regression cases across the real web/native input implementations, covering dynamic prefix, suffix, forced-active settings, currency round-trips, and populated inputs.
Include the selected currency code (or localized Any currency) in Amount and Purchase amount inputs' accessible names, so their units are available when editing. Honor explicit accessible labels in the shared text-input mode without changing numeric values or the separate currency-picker labels. Add eight regression cases for overrides, fallbacks, and currency changes.
AI Tests
abc6cd27): 122 tests passed across NumberWithSymbolForm, AmountFilterContent, BaseTextInputLabel, and BaseTextInput suites. Typecheck, explicit changed-file lint, explicit changed-file React Compiler checks, spelling, repository formatting, diff whitespace checks, and Storybook smoke test passed. Staged coding-standards review found no violations (shallow history required staged/PR-diff fallback).06601225):npm run fmtsucceeded across the repository; a second run produced no unstaged diff.git diff --cached --checkpassed. Only test-file line wrapping changed; no application behavior changed.BaseTextInputLabelTestandBaseTextInputTest. Staged coding-standards review found no violations; shallow history required a staged-diff/PR-diff fallback.npm run typecheck, Storybook smoke test,git diff --check, and staged coding-standards review (no violations).prettiernpm script no longer exists; formatting is now corrected using the repository'snpm run fmtscript. The initial compiler changed-file check lacked a CI base reference; the pre-correction CI compiler check subsequently passed.Fixed Issues
$ #106002
PROPOSAL: #106002 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
AI web verification (partial):
Accessibility update verified by computed accessible-name read-back; screenshots are visual evidence, not proof of spoken announcements:
The browser subsequently went blank, blocking the remaining lower-bound check: