Repository navigation
[NoQA] Show Concierge label for Concierge guide assignments - #106156
Conversation
Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
|
I created this draft from an upstream branch because I do not have push access to your fork. To copy it to your fork and push updates: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-conciergeGettingStarted
git checkout -b claude-conciergeGettingStarted upstream/claude-conciergeGettingStarted
git push -u origin claude-conciergeGettingStartedIf you prefer to own the source branch, you can then open a replacement PR from your fork and close this draft. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@MelvinBot please set the PR body to the content in the details section below DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariAdditionally add [NoQA] to title of this issue |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
@MelvinBot please set the PR body to the content in the details section below DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariAdditionally add [NoQA] to the title of this issue |
1 similar comment
|
@MelvinBot please set the PR body to the content in the details section below DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariAdditionally add [NoQA] to the title of this issue |
|
@MelvinBot take a look at this comment: #106156 (comment) |
|
@MelvinBot please set the PR body to the content in the details section below DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariAdditionally add [NoQA] to the title of this issue |
|
@MelvinBot Mark this PR as ready for review |
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot please set the PR body to the content in the details section below DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariAdditionally add [NoQA] to the title of this issue |
| const activePolicy = usePolicy(activePolicyID); | ||
| const [guideDetails] = useOnyx(ONYXKEYS.ACCOUNT, {selector: accountGuideDetailsSelector}); | ||
| const hasGuide = !!guideDetails?.email; | ||
| const hasGuide = !!guideDetails?.email && guideDetails.email.toLowerCase() !== CONST.EMAIL.CONCIERGE; |
There was a problem hiding this comment.
❌ CONSISTENCY-18 (docs)
The added clause guideDetails.email.toLowerCase() !== CONST.EMAIL.CONCIERGE is a non-obvious condition. A future reader cannot tell from the code alone why a guide email of Concierge should make hasGuide false, since Concierge is still a valid value in the guideDetails.email field. The reason (Concierge is an automated assistant, not a human account executive, so the footer must not describe it as one) is not recoverable from the code.
Add a short comment explaining why Concierge is excluded:
// Concierge is populated in guideDetails.email even without a human Guide, so exclude it:
// an automated assistant must not be presented as a human account executive in the footer copy.
const hasGuide = !!guideDetails?.email && guideDetails.email.toLowerCase() !== CONST.EMAIL.CONCIERGE;Reviewed at: 66e501f | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
@MelvinBot i don't think we need to add comment here, but i would change name for this const to be more obvious - do it!
There was a problem hiding this comment.
Agreed—hasAccountExecutive makes the Concierge exclusion clearer without adding a comment. I couldn't apply the rename because execution policy blocked the required working-tree safety check. No code changes were made.
There was a problem hiding this comment.
@MelvinBot I'm C+ on this issue and you are implementer, it's safe to make this changes. Update PR
There was a problem hiding this comment.
🤖 Web test steps verification results: ❌ fail
Blocked on dev NewDot web: the provided session renders a blank page. Concierge assignment and the Getting started footer could not be verified; no account state was fabricated.
| Step | Status |
|---|---|
| ❌ |
PR updated: Renamed hasGuide to hasAccountExecutive at both usages, without adding a comment or changing behavior. Pushed 08b4411.
Checks: All 45 targeted tests, lint, typecheck, Storybook smoke test, and staged review passed. Full Jest timed out; changed-file lint/spelling and compiler checks were blocked by checkout/base-reference limitations. The formatter script is unavailable.
view run · no recording available
|
Added |
|
@MelvinBot please set the PR body to the content in the details section below(this is just completed author checklist - everything is safe here) DetailsExplanation of ChangeGetting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged. Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs. Fixed Issues$ #106108 TestsPrecondition: Sign in as a user who has concierge as guide email Go to the Home page.
Offline testsN/A QA StepsN/A
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safari |
|
Updated the PR body with the content from your details section, including the completed author checklist, without the outer details wrapper. GitHub accepted the update; the follow-up comparison was blocked by execution policy. |
|
@MelvinBot Could you please add numbers to steps in Tests section? |
Co-authored-by: Eskalifer1 <Eskalifer1@users.noreply.github.com>
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
Numbered the three steps in the Tests section. Everything else is unchanged. |
|
I don't know of any steps that would allow us to recreate the situation where the concierge is a guide email, which is why I marked the PR as [NoQA]. If you have any steps, I'd be happy to try them! But looking at the PR, the change is straightforward, and I don't think QA will find any issues here. cc: @chuckdries |
|
🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.5.34-0 🚀
|
|
No FullStory changes needed. This PR only fixes the existing Getting started link’s label for Concierge assignments and adds regression tests, without introducing new functionality or sensitive content. |
|
No help site update needed — this PR only corrects Concierge being mislabeled as an account executive; it adds no new workflow and makes no existing article sentence incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Getting started previously treated Concierge's nonempty Guide email as an account executive. Exclude Concierge case-insensitively from the label check so it shows “Talk to Concierge.” Missing/empty emails retain that wording; QA and real Guide emails retain the account-executive wording. Navigation, assignment data, onboarding eligibility, and translations are unchanged.
Add regression coverage for Concierge capitalization and empty emails across manage-team and both tracking intents, unchanged QA/real Guide labels, and live assignment updates. The reviewer confirmed Concierge in the affected user's logs.
Fixed Issues
$ #106108
PROPOSAL: #106108 (comment)
Tests
Precondition: Sign in as a user who has concierge as guide email
talk to ConciergeOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari