Repository navigation
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@MelvinBot @codex please review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 834eac83de
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0889334cda
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@getusha C+ review not needed, please ignore |
|
PR doesn’t need product input as a tooling PR. Unassigning and unsubscribing myself. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00ff01e9f8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR only strengthens lint rules and types for existing Sentry labels and refactors label propagation, without adding user-facing functionality. |
|
No help site update needed — this PR changes developer lint rules, types, and internal telemetry labels without adding a user-facing feature, changing workflows, or making existing article instructions incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds lint rules that require a
CONST.SENTRY_LABELvalue on pressables and on every component that forwardssentryLabelto one (Button,MenuItem,PopoverMenu.Item,ThreeDotsMenu, ...). Also typessentryLabelasSentryLabelso plain strings fail typecheck. Existing usages are grandfathered; follow-ups label each wrapper, then a required prop replaces the rule.Fixed Issues
$ #105523
PROPOSAL: N/A
Tests
Wrapper with a press handler
src/, add<Button text="Test" onPress={() => {}} />without asentryLabelnpm run lint-changedno-restricted-syntax: "Button, MenuItem and other pressable wrappers that handle a press must have a sentryLabel from CONST.SENTRY_LABEL"sentryLabel={CONST.SENTRY_LABEL.HEADER.MORE_BUTTON}and runnpm run lint-changedagainonPressandsentryLabeland runnpm run lint-changedagainWrapper that handles its own press
src/, add<ThreeDotsMenu menuItems={[]} />without asentryLabelnpm run lint-changedno-restricted-syntax: "ThreeDotsMenu, DropdownButton and other wrappers that handle their own press must have a sentryLabel from CONST.SENTRY_LABEL"Plain string label
src/, add<PressableWithFeedback accessibilityLabel="Test" sentryLabel="Test-Label" />npm run typecheck"Test-Label"isn't assignable toSentryLabelOffline tests
N/A
QA Steps
None. This PR only changes lint rules and types, so there's no runtime change to test on staging.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari