Skip to content

[No QA] Remove unused network loading key - #10633

Merged
luacmartins merged 4 commits into
mainfrom
tgolen-remove-loadingkey
Aug 29, 2022
Merged

luacmartins merged 4 commits into
mainfrom
tgolen-remove-loadingkey

Conversation

@tgolen

@tgolen tgolen commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Details

This is no longer used since the reconnection spinner was removed from the avatar

Fixed Issues

Tests

None

  • Verify that no errors appear in the JS console

@tgolen
tgolen requested a review from luacmartins August 29, 2022 07:14
@tgolen tgolen self-assigned this Aug 29, 2022
@tgolen
tgolen marked this pull request as ready for review August 29, 2022 07:14
@tgolen
tgolen requested a review from a team as a code owner August 29, 2022 07:14
@melvin-bot
melvin-bot Bot requested review from srikarparsi and removed request for a team August 29, 2022 07:15
import _ from 'underscore';
import NetInfo from '@react-native-community/netinfo';
import AppStateMonitor from './AppStateMonitor';
import promiseAllSettled from './promiseAllSettled';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promiseAllSettled seems to be unused in the code base now. I think we should remove it as well.

@tgolen

tgolen commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

Updated

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins

Copy link
Copy Markdown
Contributor

Can we add a link to an issue or comment so we can track where these changes are coming from?

@luacmartins
luacmartins merged commit 487adc2 into main Aug 29, 2022
@luacmartins
luacmartins deleted the tgolen-remove-loadingkey branch August 29, 2022 08:36
@OSBotify OSBotify mentioned this pull request Aug 29, 2022
14 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants