Repository navigation
[No QA] Remove unused network loading key - #10633
Merged
Merged
Conversation
tgolen
marked this pull request as ready for review
August 29, 2022 07:14
melvin-bot
Bot
requested review from
srikarparsi
and removed request for
a team
August 29, 2022 07:15
luacmartins
reviewed
Aug 29, 2022
| import _ from 'underscore'; | ||
| import NetInfo from '@react-native-community/netinfo'; | ||
| import AppStateMonitor from './AppStateMonitor'; | ||
| import promiseAllSettled from './promiseAllSettled'; |
Contributor
There was a problem hiding this comment.
promiseAllSettled seems to be unused in the code base now. I think we should remove it as well.
Contributor
Author
|
Updated |
Contributor
|
Can we add a link to an issue or comment so we can track where these changes are coming from? |
14 tasks done
Contributor
|
🚀 Deployed to staging by @luacmartins in version: 1.1.93-1 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This is no longer used since the reconnection spinner was removed from the avatar
Fixed Issues
Tests
None