Repository navigation
Guard missing workspace domain verification parameters - #106614
Conversation
Co-authored-by: abdulrahuman5196 <abdulrahuman5196@users.noreply.github.com>
|
I created this PR from an upstream branch because an accessible contributor fork was not found. To copy the branch to your fork and push updates yourself, run: git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-guardMissingDomainParams
git checkout -b claude-guardMissingDomainParams upstream/claude-guardMissingDomainParams
git push -u origin claude-guardMissingDomainParamsYou can then close this draft and open a replacement PR from your fork. |
|
🤖 Web test steps verification results: Verified invalid-route recovery on dev NewDot web. Valid-domain verification and the console-error assertion remain blocked.
|
|
🤖 Android test steps verification results: Verified both boundary URLs on standalone Android NewDot. This does not reproduce the reported HybridApp crash or prove execution with undefined route.params.
|
|
@MelvinBot |
|
Marked the PR ready for review. You can add the remaining details later; the description and checklist are unchanged. |
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@MelvinBot could you update the test section with the below information and also check all the check boxes in authors checklist Tests
Offline testsN/A QA StepsSame as Tests. |
|
Updated Tests, Offline tests, and QA Steps with your supplied text, and checked all PR Author Checklist boxes on your behalf. No tests were rerun. |
|
No product review needed. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroidHybrid-0-Screen_Recording_2026-11-19_at_12.46.31.AM.movAndroid: mWeb ChromeiOS: HybridAppiosHybrid-0-Screen_Recording_2026-11-19_at_12.17.44.AM.moviOS: mWeb SafariiosMWeb-0-Screen_Recording_2026-11-19_at_12.30.31.AM.movMacOS: Chrome / SafarimacOS-0-Screen_Recording_2026-11-18_at_9.19.04.PM.mov |
|
I am having setup issue with android chrome, but checked all other platform. IMO this shouldn't block the merge, do let me know otherwise. |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @mountiny
🎀 👀 🎀
C+ Reviewed
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR prevents a crash when domain verification opens without a domain ID; it adds no new workflow and leaves the documented verification steps unchanged. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
Safely read the verification screen's domain account ID and show the existing dismissible not-found page when it is missing. This prevents a render-time crash before domain validation and avoids constructing destination routes with an absent ID. Valid-ID behavior is unchanged.
Add regression coverage for undefined params and an empty params object, asserting that the fallback renders without mounting the verification flow or requesting a validation code. The upstream navigation trigger remains unconfirmed; this is the approved defensive fix.
AI Tests
npm run lint,npm run lint-changed,npm run typecheck,npm run spell-changed, Storybook smoke test, and direct React Compiler check of the changed screen.Fixed Issues
$ #106405
PROPOSAL: #106405 (comment)
Tests
workspaces/verify-domain/123456789(unknown / non-existent domain ID).workspaces/verify-domainwith no domain ID.workspaces/verify-domain/<validDomainAccountID>for a domain you can verify.Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Web verification was blocked by a blank handed-off session; this screenshot documents the blocker, not successful verification.