Repository navigation
MenuItem: migrate GL code, 2FA disable, and accounting connection rows - #106639
Conversation
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🤖 Android test steps verification results: Recovered sign-in and completed onboarding on Android. Verified that the empty GL-code row has a chevron and opens the Control-plan upgrade screen; remaining checks are unverified due to missing fixtures and the testing limit. Light/dark coverage was not completed.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
|
🤖 Web test steps verification results: ❌ fail Partial QA completed on Web before an emailed account-validation code blocked further testing; no product regression was established. Wide/narrow light layouts were exercised; dark theme was not tested.
view run · no recording available |
Co-authored-by: Pujan Shah <Pujan92@users.noreply.github.com>
|
Pushed eddc3346 to fix Oxfmt’s import-order failure.
CI is rerunning; its results are not yet confirmed. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
NAB: no need to tighten the seatbelt manually. It happens automatically on merge
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.5.37-0 🚀
|
|
No help site update needed — this PR migrates existing menu components without adding features, changing documented workflows or labels, removing beta gates, or making existing article text incorrect. |
|
@Pujan92 @heyjennahay We will verify only steps 1-6, as don't have access to Sentry
|
|
@izarutskaya yes, ignore that step |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.37-1 🚀
Bundle Size Analysis (Sentry): |






Explanation of Change
Migrate only the four requested rows away from the legacy configuration API, without changing their existing Sentry labels or adding presets/props:
AI Tests
npm run fmtis idempotent; lint, lint-changed, spell-changed, explicit React Compiler checks for all four changed pages, Storybook smoke test, and 3 targeted Jest suites / 278 tests passed. Code-standards review found no violations.allTransactionViolationsarguments; the affected action and test files are byte-identical at the PR parent and head. Compilercheck-changedstill lacks its CI base ref; explicit checks passed. No browser QA was rerun for the import-only fix.npm run lint; explicit React Compiler checks for all four changed pages; 9 targeted Jest suites / 253 tests (menu fields, accessibility, read-only rules, session, policy tags); Storybook smoke test.allTransactionViolationsarguments (untouched by this PR).lint-changed/ spelling wrapper checks were blocked by fetch/merge-base failures in this shallow checkout. Compilercheck-changedcould not resolve its empty CI base ref; explicit per-file compiler checks passed instead.prettierscript); standalone formatter/spelling invocations were denied by the execution policy.Fixed Issues
$ #100159
PROPOSAL: #100159 (comment)
Tests
// TODO: The human co-author must fill out the tests they ran. Automated checks and the blocked browser attempt are recorded under AI Tests above.
Offline tests
With the relevant screens already loaded, go offline and repeat the editable/locked GL-code and 2FA navigation checks below. Confirm rows retain their icons, permissions, and existing offline feedback. Do not submit external accounting credentials. These steps have not been executed.
QA Steps
Run on wide and narrow web layouts, in light and dark themes:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web verification was blocked before reaching any changed row:

Contributor branch access
This PR uses an upstream branch because Melvin cannot push to the requester's fork. To copy it to your fork:
You can then close this PR and open one from your fork if needed.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari