Repository navigation
Render left navigation destinations as real links - #106937
Conversation
Add a linkRoute prop to GenericPressable that renders the route as an href on web. A plain click prevents the browser navigation and runs the in-app onPress, while Cmd/Ctrl clicks are left to the browser so the destination opens in a new tab. Right-click "Open link in new tab" and middle-click work through the native anchor. Use it for every destination in NavigationTabBar and FlatNavigationBar: logo, Home, Inbox, Spend, Insights, Workspaces and Account. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Select only queryJSON and searchKey for the stored Spend route, so the tab bars don't re-render when search pagination fields change. Share the default Insights route between the tab bars and getInsightsTabRoute. Add the missing When comment to the link test. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e85eee240a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Anonymous users get no href on gated tabs, so a Cmd click still shows the sign-in prompt. Disabled pressables render no href, so the context menu cannot open them. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Eskalifer1
left a comment
There was a problem hiding this comment.
TabBarLabel renders the label twice, once visible and once as an aria-hidden bold copy that reserves the width. Now that the tab is an <a href>, the link's text content contains both copies, so dragging a tab shows a doubled title such as "HomeHome". aria-hidden only hides the copy from assistive tech and does not remove it from the text content.
2026-11-16.09.19.46.mov
| onAccessibilityTap={!isDisabled ? voidOnPressHandler : undefined} | ||
| accessible={accessible} | ||
| fsClass={forwardedFSClass} | ||
| href={linkRoute && !isDisabled && !fullDisabled ? `/${linkRoute}` : undefined} |
There was a problem hiding this comment.
href is dropped for disabled and fullDisabled, but not for interactive={false}, which makes onPressHandler a no-op. A non-interactive pressable with linkRoute still renders a real <a>, so Cmd+click opens a new tab while a plain click does nothing.
There was a problem hiding this comment.
Fixed. The href now also checks interactive.
|
@MelvinBot Review this PR from a11y side |
|
🤖 Web test steps verification results: No confirmed PR-introduced accessibility regressions. Wide and narrow navigation have meaningful accessible names, but keyboard behavior, focus visibility/order, and screen-reader link discovery remain unverified.
|
|
@MelvinBot Look at this PR from a11y side only by code |
Code-only accessibility reviewNo confirmed accessibility regressions introduced by this PR. Reviewed commit
Non-blocking observations
Home’s missing selected state and the existing tab Space-key limitation predate this change; I would not block this PR on them. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp106937-android-native.movAndroid: mWeb Chrome106937-android-web.moviOS: HybridApp106937-ios-native.moviOS: mWeb Safari106937-ios-web.movMacOS: Chrome / Safari106937-web.mov |
Read the session once per component for gated link routes. Share one helper for turning a route into a path. Drop the href for non-interactive pressables. Leave Shift clicks and Enter on links to the browser so they open a new window or tab like a real link. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
The hidden bold copy that reserves a tab label's width was part of the link's text content, so dragging a tab showed the title twice. On web it is now drawn by a CSS pseudo-element, which reserves the same width without adding text. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Good catch. On web the bold placeholder is now a CSS |
|
Hi @Krishna2323 i don't see any update here.. Did you push your changes? |
Sorry I forgot to push the commits, now updated. |
|
Sorry for the delay! Reviewing it now again |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Eskalifer1
left a comment
There was a problem hiding this comment.
Seems like default Alt(or Option) click downloads .txt file(error) instead of .html. I think it's better to remove this option
2026-11-17.18.24.00.mov
…debar-links Signed-off-by: krishna2323 <belivethatkg@gmail.com> # Conflicts: # src/components/Pressable/GenericPressable/types.ts
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hi @Krishna2323! What about this one? |
@Eskalifer1, the |
…323/105770-sidebar-links Signed-off-by: krishna2323 <belivethatkg@gmail.com> # Conflicts: # src/components/Pressable/GenericPressable/implementation/BaseGenericPressable.tsx
Eskalifer1
left a comment
There was a problem hiding this comment.
Thank you for PR @Krishna2323!
LGTM!
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.43-0 🚀
|
|
No help site update needed — this restores expected browser behavior for opening existing navigation destinations in new tabs, without changing documented workflows or making any existing article sentence incorrect. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
Adds a
linkRouteprop toGenericPressable. When it's set, the pressable renders as a real link (<a href="/<route>">) on web:onPressnavigates inside the app.This is the first PR for the issue. It adds the shared support and uses it in the left navigation: the logo, Home, Inbox, Spend, Insights, Workspaces and Account, in both the icon tab bar and the flat navigation bar.
A new tab has no navigation history, so each link points to that tab's starting page:
A plain click still restores the last page you had open in that tab, as before. Native ignores
href, so mobile apps are unchanged.Fixed Issues
$ #105770
PROPOSAL:
Tests
Offline tests
Same as tests. Navigation is client-side, so the behavior is the same offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-11-15.07-33-43.mp4