Skip to content

Remove useOnyx loading status reads from workspace archive, delete, copy settings and downgrade pages - #106981

Merged
mountiny merged 3 commits into
Expensify:mainfrom
callstack-internal:VickyStash/refactor/104583-workspace-onyx-status-pt6
Nov 19, 2026
Merged

mountiny merged 3 commits into
Expensify:mainfrom
callstack-internal:VickyStash/refactor/104583-workspace-onyx-status-pt6

Conversation

@VickyStash

@VickyStash VickyStash commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

This continues the Workspace cleanup from #106824. This part covers the archive, delete, copy settings and downgrade flows, a few other policy-level pages, and withPolicy.

Once the app has started, useOnyx only returns loading when a key has nothing in the cache yet and an Onyx.merge for it hasn't been applied. None of these pages can run into that:

  • The archive, unarchive and delete flows mount when you pick the action from a menu. Nothing writes to the keys they read at that moment, and the policy is already cached because it's on screen. The policies, reports, transactions and violations collections are never loading after startup.
  • The copy settings steps only open the upgrade and confirm pages after setCopyPolicySettingsData resolves, so the merge has already been applied.
  • The pay and downgrade page opens only after the bill calculation finishes, so the billing receipt details are already in Onyx.
  • The tag GL code and time tracking default rate pages are opened from pages that already read the same keys. The append tag list flow merges into the imported spreadsheet and then opens the import page, but the page renders after that merge has been applied.
  • withPolicy and the join workspace page read a single policy that nothing merges while they mount.

So I removed the loading checks, the metadata variables, and the loader in the pay and downgrade page that only rendered while loading.

Fixed Issues

$ #104583
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Use an account that owns

  • Control workspace (with rules and a few tags)
  • Collect workspace.
  1. Create a new workspace. Verify you land on its overview without a not-found page.
  2. Go to Workspaces, open the More menu on that workspace and choose Delete. Verify the confirmation modal shows, confirm, and verify the workspace is deleted.
  3. Open the three-dot menu on the Control workspace and choose Copy settings. Pick the Collect workspace as the target and select Rules. Verify the upgrade step shows. Upgrade, continue, and verify the confirm page lists the selected settings. Press Copy and verify the settings are copied.
  4. On the Control workspace go to Tags, open a tag and press GL code. Change it, save, and verify the new code shows.
  5. Go to Tags > More > Import spreadsheet and choose Single level of tags. Verify the import page opens and that you can upload a file.
  6. Turn on Time tracking in More features, go to Time tracking and press Default rate. Change it, save, and verify the new rate shows.
  7. On the overview choose More > Share and copy the link. Open it and verify you're taken to the workspace.

Archive workspace:

  1. With the archivePolicies beta, open the More menu on a workspace you own and choose Archive. Verify the confirmation modal shows, confirm, and verify the workspace is archived.
  2. Open the menu on the archived workspace, choose Unarchive and confirm. Verify the workspace is restored.

Note: archiving is not possible in my test account

Offline tests

Same, as in Tests section

QA Steps

Same, as in Tests section

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android.mp4
iOS: Native
ios1.mp4
ios2.mov
MacOS: Chrome / Safari
web1.mp4
web2.mp4

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useTransactionViolationOfWorkspace.tsx 96.29% <100.00%> (-0.38%) ⬇️
...pyPolicySettings/CopyPolicySettingsConfirmPage.tsx 91.86% <100.00%> (-0.10%) ⬇️
...pyPolicySettings/CopyPolicySettingsUpgradePage.tsx 96.77% <100.00%> (-0.06%) ⬇️
src/pages/workspace/withPolicy.tsx 100.00% <100.00%> (ø)
...workspace/downgrade/DynamicPayAndDowngradePage.tsx 0.00% <0.00%> (ø)
src/pages/workspace/tags/ImportTagsPage.tsx 0.00% <0.00%> (ø)
...kspace/archiveWorkspace/UnarchiveWorkspaceFlow.tsx 0.00% <0.00%> (ø)
src/pages/workspace/tags/DynamicTagGLCodePage.tsx 0.00% <0.00%> (ø)
...eTracking/WorkspaceTimeTrackingDefaultRatePage.tsx 0.00% <0.00%> (ø)
...orkspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx 0.00% <0.00%> (ø)
... and 2 more
... and 9 files with indirect coverage changes

@VickyStash
VickyStash marked this pull request as ready for review November 16, 2026 13:33
@VickyStash
VickyStash requested review from a team as code owners November 16, 2026 13:33
@expensify-chore-bot
expensify-chore-bot Bot requested review from JmillsExpensify and nkdengineer and removed request for a team November 16, 2026 13:33
@expensify-chore-bot

Copy link
Copy Markdown

@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@expensify-chore-bot
expensify-chore-bot Bot removed the request for review from a team November 16, 2026 13:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T13:50:24.541099Z 1e04a00 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing steps look good to me.

@nkdengineer

nkdengineer commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-18.at.12.29.57.mov
Android: mWeb Chrome
Screen.Recording.2026-11-18.at.12.28.33.mov
iOS: HybridApp
Screen.Recording.2026-11-18.at.12.29.14.mov
iOS: mWeb Safari
Screen.Recording.2026-11-18.at.12.30.33.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-18.at.12.23.35.mov
Screen.Recording.2026-11-18.at.12.27.25.mov

@nkdengineer

Copy link
Copy Markdown
Contributor

@mountiny The test requires archivePolicies beta. Please add my account nkdengineer+cplus1@outlook.com to the beta. Thanks.

@mountiny

Copy link
Copy Markdown
Contributor

@nkdengineer done, give it an hour

@nkdengineer nkdengineer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from mountiny November 18, 2026 05:33

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mountiny
mountiny merged commit 9b40d20 into Expensify:main Nov 19, 2026
37 of 41 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR only removes redundant internal loading checks without adding features, changing documented workflows, or removing beta gates.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants