Repository navigation
Remove useOnyx loading status reads from workspace archive, delete, copy settings and downgrade pages - #106981
Conversation
…opy settings and downgrade pages
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Testing steps look good to me.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-18.at.12.29.57.movAndroid: mWeb ChromeScreen.Recording.2026-11-18.at.12.28.33.moviOS: HybridAppScreen.Recording.2026-11-18.at.12.29.14.moviOS: mWeb SafariScreen.Recording.2026-11-18.at.12.30.33.movMacOS: Chrome / SafariScreen.Recording.2026-11-18.at.12.23.35.movScreen.Recording.2026-11-18.at.12.27.25.mov |
|
@mountiny The test requires |
|
@nkdengineer done, give it an hour |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR only removes redundant internal loading checks without adding features, changing documented workflows, or removing beta gates. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This continues the Workspace cleanup from #106824. This part covers the archive, delete, copy settings and downgrade flows, a few other policy-level pages, and
withPolicy.Once the app has started,
useOnyxonly returnsloadingwhen a key has nothing in the cache yet and anOnyx.mergefor it hasn't been applied. None of these pages can run into that:loadingafter startup.setCopyPolicySettingsDataresolves, so the merge has already been applied.withPolicyand the join workspace page read a single policy that nothing merges while they mount.So I removed the loading checks, the metadata variables, and the loader in the pay and downgrade page that only rendered while loading.
Fixed Issues
$ #104583
PROPOSAL:
Tests
Use an account that owns
Archive workspace:
archivePoliciesbeta, open the More menu on a workspace you own and choose Archive. Verify the confirmation modal shows, confirm, and verify the workspace is archived.Note: archiving is not possible in my test account
Offline tests
Same, as in Tests section
QA Steps
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
iOS: Native
ios1.mp4
ios2.mov
MacOS: Chrome / Safari
web1.mp4
web2.mp4