Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaritest.mov |
|
Please fix conflict |
situchan
left a comment
There was a problem hiding this comment.
Old personalDetailsMetadata stays on disk
Existing users keep the old object (one entry per profile ever opened) until sign-out, since nothing removes it.
Optional: a small migration in src/libs/migrations/ that sets it to null.
No test for the new key
Add a test that openPublicProfilePage(id) sets personalDetailsLoadingState_<id> to isLoading: true, then false.
I don't think we need a migration here since it's a front-end key only. |
|
@situchan I've updated. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR only optimizes internal profile-loading state without changing user-facing features, workflows, or labels, so existing articles remain accurate. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Problem
When a user opens a profile, we store its loading state in one
personalDetailsMetadataobject keyed by accountID. Every profile screen subscribes to that whole object to read one account's flag, so opening any profile re-renders every other profile screen that is still open (e.g. profile A → tap a participant → profile B re-renders A).How bad it gets, with account 1's avatar open and 20 other profiles opened on top:
• Account 1 re-renders once for every other profile opened, even though its own data never changed.
• The object is saved to disk and gains an entry for every profile ever opened until sign-out, so each write merges into an object that keeps growing.
The key is written here, and read here and here.
Solution
personalDetailsLoadingState_<accountID>, so each screen only subscribes to its own account.reportLoadingState_,companyCardsLoadingState_), so it no longer grows on disk.The output is the same as main: it's only a loading flag, and no other screen or the server reads it.
Fixed Issues
$ #107188
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-11-18.at.12.47.03.mov
Android: mWeb Chrome
Screen.Recording.2026-11-18.at.12.45.10.mov
iOS: Native
Screen.Recording.2026-11-18.at.12.46.47.mov
iOS: mWeb Safari
Screen.Recording.2026-11-18.at.12.45.44.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-18.at.12.43.34.mov