Repository navigation
Don’t repeat the tax percentage when a tax rate name already ends with it - #107091
neil-marcellini merged 14 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Makes sense to me.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2353abffea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@dominictb The distance-rate changelog still appends the percentage. Don't we need to fix here too? 107091-issue-001.mp4 |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp107091-android-hybrid-001.mp4Android: mWeb Chrome107091-mweb-chrome-001.mp4iOS: HybridApp107091-ios-hybrid-001.mp4iOS: mWeb Safari107091-mweb-safari-001.mp4MacOS: Chrome / Safari107091-web-chrome-001.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Thanks @dominictb for the updates.
@neil-marcellini Changes LGTM.
Approving for your review.
…ate-percentage # Conflicts: # src/libs/ReportActionsUtils.ts # src/libs/TransactionUtils/tax.ts
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good thank you
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR fixes duplicated percentages in tax rate labels without adding a feature, changing a workflow, or making existing article instructions incorrect. |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.47-0 🚀
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Problem
App always adds the percentage after a tax rate's name. The
Standard VAT (20%)rate that Auth creates for UK fuel-band distance rates therefore shows asStandard VAT (20%) (20%). It appears in the tax pickers, the expense tax field, the distance rate details page, the rule pages and the category tax rate log.Solution
Added
formatTaxRateName(name, value)toPolicyUtils/tax.ts. It returns the name unchanged when the name already ends with(value), and adds(value)otherwise. Every place that built a${name} (${value})label now uses it.Fixed Issues
$ #106874
PROPOSAL:
Tests
Standard VAT (20%)with value20%Standard VAT (20%)Standard VAT (20%), notStandard VAT (20%) (20%)Offline tests
NA
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari