Repository navigation
[NoQA] Fix typecheck error in SplitTest after personalDetailsByLogins became required - #107641
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
expensify-chore-bot
Bot
requested review from
marcochavezf
and removed request for
a team
November 21, 2026 03:13
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ All modified and coverable lines are covered by tests. |
francoisl
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
typecheckjob onmainfails after #107536. That PR madepersonalDetailsByLoginsrequired inRequestMoneyInformation, and onerequestMoneycall intests/actions/IOUTest/SplitTest.tsstill left it out. TypeScript reportsTS2741atSplitTest.ts(3211,22).This PR passes
personalDetailsByLogins: RORY_PERSONAL_DETAILS_BY_LOGINSto that call. The otherrequestMoneycalls in the same file already pass it the same way. The change touches a test file only.Failing run: https://github.com/Expensify/App/actions/runs/44858758283/job/136707021269
Fixed Issues
$ #107640
PROPOSAL:
Tests
npm run typecheck.npx jest tests/actions/IOUTest/SplitTest.ts.Offline tests
N/A. This PR only changes a test file.
QA Steps
No QA. This PR only changes a test file, so there is no behavior to check in the app.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Not yet tested — needs manual QA.
Android: mWeb Chrome
Not yet tested — needs manual QA.
iOS: Native
Not yet tested — needs manual QA.
iOS: mWeb Safari
Not yet tested — needs manual QA.
MacOS: Chrome / Safari
Not yet tested — needs manual QA.