Skip to content

show tooltip for emoji picker button on hover the outer part - #13612

Merged
thienlnam merged 1 commit into
Expensify:mainfrom
situchan:fix/13455-tooltip-hover-emoji
Dec 15, 2022
Merged

thienlnam merged 1 commit into
Expensify:mainfrom
situchan:fix/13455-tooltip-hover-emoji

Conversation

@situchan

Copy link
Copy Markdown
Contributor

Details

  • Wrap Pressable with Tooltip
  • Apply style to Tooltip container for multiline responsive

Fixed Issues

$ #13455
PROPOSAL: #13455 (comment)

Tests

  1. Login the app
  2. Open any chat room
  3. In composer, hover on the clickable area of emoji button but the outer part of emoji icon
  4. Verify that Emoji tooltip shows
  • Verify that no errors appear in the JS console

Offline tests

  1. Login the app
  2. Open any chat room
  3. Disable network
  4. In composer, hover on the clickable area of emoji button but the outer part of emoji icon
  5. Verify that Emoji tooltip shows

QA Steps

  1. Login the app
  2. Open any chat room
  3. In composer, hover on the clickable area of emoji button but the outer part of emoji icon
  4. Verify that Emoji tooltip shows
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome

mchrome

Mobile Web - Safari

msafari

Desktop
desktop.mov
iOS

ios

Android

android

@situchan
situchan requested a review from a team as a code owner December 15, 2022 10:06
@melvin-bot
melvin-bot Bot requested review from aimane-chnaif and thienlnam and removed request for a team December 15, 2022 10:06
@melvin-bot

melvin-bot Bot commented Dec 15, 2022

Copy link
Copy Markdown

@thienlnam @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@aimane-chnaif

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome

mchrome

Mobile Web - Safari

msafari

Desktop
desktop.mov
iOS

ios

Android

android

@aimane-chnaif aimane-chnaif left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 and tests well

cc: @thienlnam

@thienlnam thienlnam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@thienlnam
thienlnam merged commit 0d62cc2 into Expensify:main Dec 15, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
TTI 825.989 ms → 834.089 ms (+8.100 ms, +1.0%)
runJsBundle 198.871 ms → 206.125 ms (+7.254 ms, +3.6%)
nativeLaunch 9.935 ms → 10.033 ms (+0.098 ms, +1.0%)
regularAppStart 0.014 ms → 0.015 ms (+0.001 ms, +7.2%)
Show details
Name Duration
TTI Baseline
Mean: 825.989 ms
Stdev: 50.534 ms (6.1%)
Runs: 728.2141009999905 756.0943179999013 775.001360999886 775.7814670000225 787.3507920000702 787.4321079999208 790.5024439999834 792.4593509999104 792.8298259999137 794.4660589999985 800.1296049999073 802.291850999929 807.5122030000202 813.0940400001127 815.7450659999158 816.15909500001 817.0769030000083 821.9578180001117 822.680102000013 826.7333730000537 828.1805680000689 832.8084360000212 839.7046179999597 843.3064379999414 847.435068000108 892.1515130000189 903.1953219999559 908.4139930000529 921.6068059999961 927.3516959999688 938.0080889998935

Current
Mean: 834.089 ms
Stdev: 39.567 ms (4.7%)
Runs: 765.0894780000672 782.9605660000816 786.7523350000847 789.6348089999519 791.8322960000951 792.6420420000795 802.5413399999961 802.655391999986 803.0419069998898 803.7631699999329 809.0185239999555 811.5995700000785 815.079209000105 825.7157850000076 826.3858970000874 834.0083920001052 834.918866999913 835.3404439999722 844.071382000111 845.2139709999319 850.1824789999519 851.0823150000069 851.2810200001113 862.3718960001133 866.8964509998914 876.5299360000063 877.643548999913 877.8285370001104 903.6270419999491 906.4361749999225 930.6145329999272
runJsBundle Baseline
Mean: 198.871 ms
Stdev: 23.718 ms (11.9%)
Runs: 164 166 170 172 175 178 180 183 184 185 185 186 188 188 191 194 196 197 197 200 206 207 212 212 216 223 234 238 241 243 254

Current
Mean: 206.125 ms
Stdev: 24.772 ms (12.0%)
Runs: 163 171 171 173 176 180 183 189 189 191 195 195 198 198 199 202 207 208 210 213 214 214 215 222 227 228 231 232 241 249 250 262
nativeLaunch Baseline
Mean: 9.935 ms
Stdev: 1.813 ms (18.2%)
Runs: 8 8 8 8 8 8 8 9 9 9 9 9 9 9 9 9 9 10 10 10 10 11 11 11 12 12 12 12 12 14 15

Current
Mean: 10.033 ms
Stdev: 1.538 ms (15.3%)
Runs: 8 8 8 9 9 9 9 9 9 9 9 9 9 10 10 10 10 10 10 10 10 10 11 11 11 11 12 13 14 14
regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (5.7%)
Runs: 0.012614000122994184 0.012654999969527125 0.012857999885454774 0.012858000118285418 0.013427999801933765 0.013671999797224998 0.013672000030055642 0.013672000030055642 0.01395700010471046 0.01395700010471046 0.014160000020638108 0.014322999864816666 0.01432300009764731 0.014567000092938542 0.014648000011220574 0.014649000018835068 0.014649000018835068 0.014688999857753515 0.014811000088229775 0.014812000095844269 0.014851999934762716 0.014892000006511807 0.0148930000141263 0.014933999860659242 0.015137000009417534 0.015176999848335981 0.015381000004708767 0.015503000002354383

Current
Mean: 0.015 ms
Stdev: 0.001 ms (5.6%)
Runs: 0.014038000022992492 0.014322999864816666 0.01432300009764731 0.01432300009764731 0.01436399994418025 0.014484999934211373 0.014484999934211373 0.01448600017465651 0.014607999939471483 0.014688999857753515 0.014771000016480684 0.0148930000141263 0.0148930000141263 0.014974000165238976 0.015055000083521008 0.015096000162884593 0.01521800016053021 0.015257999999448657 0.015421000076457858 0.015746999997645617 0.015746999997645617 0.015787999844178557 0.0157880000770092 0.015828999923542142 0.016072999918833375 0.01607300015166402 0.016193999908864498 0.016438999911770225 0.0165200000628829 0.01704900013282895 0.01745599997229874

@OSBotify OSBotify mentioned this pull request Dec 16, 2022
25 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.2.41-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.2.41-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.2.41-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@situchan
situchan deleted the fix/13455-tooltip-hover-emoji branch November 4, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants