Skip to content

[Core Branding] Make icons less chunky - #13641

Merged
grgia merged 1 commit into
mainfrom
georgia-iconFix
Dec 16, 2022
Merged

grgia merged 1 commit into
mainfrom
georgia-iconFix

Conversation

@grgia

@grgia grgia commented Dec 15, 2022 •

Copy link
Copy Markdown
Contributor

Details

This PR replaces the upload, download, and send icons. It also replaces the upload-alt icon, which is not currently used in App, so no QA for that icon.

Fixed Issues

$ #13637

Tests

  • Verify that no errors appear in the JS console
  • Go to upload an avatar > ensure that the upload icon looks correct
  • Type in compose bar > ensure that the send icon looks correct
  • Add an attachment > hover or hold on attachment > ensure that the download icon looks correct

Offline tests

QA Steps

  • Verify that no errors appear in the JS console
  • Same as Tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web image image
Mobile Web - Chrome image image image
Mobile Web - Safari image image image
Desktop image image
iOS image image image
Android image image image

@grgia
grgia requested a review from shawnborton December 15, 2022 21:24
@grgia grgia self-assigned this Dec 15, 2022
@grgia
grgia marked this pull request as ready for review December 15, 2022 21:24
@grgia
grgia requested a review from a team as a code owner December 15, 2022 21:24
@melvin-bot
melvin-bot Bot requested review from puneetlath and thesahindia and removed request for a team December 15, 2022 21:24
@melvin-bot

melvin-bot Bot commented Dec 15, 2022

Copy link
Copy Markdown

@thesahindia @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@thesahindia

Copy link
Copy Markdown
Member

Don't think it needs C+ review since it's a small change. Let me know if you think otherwise.
cc: @puneetlath

@puneetlath

Copy link
Copy Markdown
Contributor

@thesahindia it needs a reviewer to test on all platforms. If you're willing to do that, that would be great.

@thesahindia

Copy link
Copy Markdown
Member

Cool, will test it in a few minutes.

@thesahindia

thesahindia commented Dec 16, 2022 •

Copy link
Copy Markdown
Member

I think the send Icon feels a little misaligned because it got smaller. Is it just me?
Screenshot 2022-12-16 at 11 18 15 PM

This is how it looks after I increase the bottom margin by 1px and decrease 1px from the top margin
Screenshot 2022-12-16 at 11 17 33 PM

Adding this SS to make the difference more visible
Screenshot 2022-12-16 at 11 27 21 PM

@grgia

grgia commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

Nice catch! However, I don't think we should vary the top/bottom margin because it will be off-center when the padding is added while typing. Before I do anything, what are your thoughts on here @shawnborton?

@shawnborton

Copy link
Copy Markdown
Contributor

This isn't actually a bug at all. The measurements should be happening from the bounding box of each icon, not the icon shape itself. So I think this one is totally fine and good to go!

@thesahindia

Copy link
Copy Markdown
Member

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web Screenshot 2022-12-16 at 10 45 55 PM Screenshot 2022-12-16 at 10 48 14 PM Screenshot 2022-12-16 at 10 47 56 PM
Mobile Web - Chrome Screenshot 2022-12-16 at 11 40 24 PM Screenshot 2022-12-16 at 11 40 14 PM
Mobile Web - Safari Screenshot 2022-12-16 at 10 59 56 PM Screenshot 2022-12-16 at 10 59 47 PM Screenshot 2022-12-16 at 10 59 30 PM
Desktop Screenshot 2022-12-16 at 10 50 23 PM Screenshot 2022-12-16 at 10 50 13 PM Screenshot 2022-12-16 at 10 49 56 PM
iOS Screenshot 2022-12-16 at 10 58 02 PM Screenshot 2022-12-16 at 10 57 05 PM Screenshot 2022-12-16 at 10 56 05 PM
Android Screenshot 2022-12-16 at 11 08 29 PM Screenshot 2022-12-16 at 11 07 54 PM Screenshot 2022-12-16 at 11 33 04 PM

@thesahindia thesahindia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at all platforms.

C+ reviewed 🎀👀🎀

@grgia
grgia merged commit 977c92c into main Dec 16, 2022
@grgia
grgia deleted the georgia-iconFix branch December 16, 2022 19:44
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
TTI 812.272 ms → 832.263 ms (+19.991 ms, +2.5%)
runJsBundle 190.156 ms → 200.188 ms (+10.031 ms, +5.3%)
regularAppStart 0.016 ms → 0.015 ms (-0.001 ms, -7.5%)
nativeLaunch 9.700 ms → 9.607 ms (-0.093 ms, -1.0%)
Show details
Name Duration
TTI Baseline
Mean: 812.272 ms
Stdev: 38.140 ms (4.7%)
Runs: 739.2114690002054 754.6993450000882 761.4104399997741 766.8793879998848 771.6640159999952 772.6280319998041 774.1072660000063 781.3192859999835 783.5898440000601 783.8900810000487 800.2378440001048 802.171546000056 803.5357750002295 806.7992730000988 808.9831670001149 812.4498689998873 814.3279809998348 817.2296440000646 817.7075550002046 819.1690819999203 823.6819719998166 830.9564849999733 831.1463549998589 838.9721010001376 853.4340090001933 853.6733849998564 855.1128030000255 858.647936000023 860.6371019999497 877.678356999997 904.4792909999378

Current
Mean: 832.263 ms
Stdev: 40.850 ms (4.9%)
Runs: 770.7057969998568 772.4463769998401 780.552370000165 784.4073419999331 784.6645080000162 787.0459070000798 791.2890750002116 795.5503699998371 802.9017199999653 803.6631820001639 807.6344309998676 808.61352299992 819.2955080000684 822.8831609999761 823.4335329998285 826.5282840002328 831.9459119997919 834.5187829998322 840.9891550000757 841.1769719999284 843.2842720001936 858.5279879998416 860.4353339998052 868.6585650001653 874.579146000091 876.2869460000657 878.0956919998862 894.2315259999596 899.9799480000511 902.6297220000997 913.2060610000044
runJsBundle Baseline
Mean: 190.156 ms
Stdev: 23.008 ms (12.1%)
Runs: 156 158 160 162 164 168 169 169 171 173 174 178 178 179 181 187 188 189 193 195 197 205 207 207 211 215 218 221 222 224 228 238

Current
Mean: 200.188 ms
Stdev: 26.009 ms (13.0%)
Runs: 165 165 167 167 168 168 173 175 178 180 182 185 189 193 193 195 203 203 207 209 209 211 214 219 224 225 228 236 238 240 247 250
regularAppStart Baseline
Mean: 0.016 ms
Stdev: 0.001 ms (8.4%)
Runs: 0.014607999939471483 0.014649000018835068 0.014649000018835068 0.014690000098198652 0.014810999855399132 0.014810999855399132 0.015054999850690365 0.01509599993005395 0.015420999843627214 0.015583999920636415 0.015746999997645617 0.015746999997645617 0.01582799991592765 0.015828999690711498 0.01590899983420968 0.01590999960899353 0.015910000074654818 0.015910000074654818 0.016031999606639147 0.016112999990582466 0.016193999908864498 0.0163569999858737 0.016480000223964453 0.01704900013282895 0.017659000121057034 0.01769999973475933 0.017700000200420618 0.018025000113993883 0.018025999888777733 0.018391999881714582 0.02071200031787157

Current
Mean: 0.015 ms
Stdev: 0.001 ms (5.9%)
Runs: 0.01375299971550703 0.013793999794870615 0.01383400009945035 0.013915999792516232 0.013955999631434679 0.014037999790161848 0.014200999867171049 0.014241999946534634 0.01444500032812357 0.014485000167042017 0.014525999780744314 0.014566999860107899 0.01460800040513277 0.014771000016480684 0.014810999855399132 0.014810999855399132 0.0148930000141263 0.014973999932408333 0.01497400039806962 0.015137000009417534 0.015176999848335981 0.015339999925345182 0.015340999700129032 0.015381000004708767 0.0157880000770092 0.01582799991592765 0.015828000381588936 0.015949999913573265 0.016112999990582466 0.01615400006994605 0.01696799974888563 0.017293000128120184
nativeLaunch Baseline
Mean: 9.700 ms
Stdev: 1.935 ms (19.9%)
Runs: 7 7 7 8 8 8 8 9 9 9 9 9 9 9 9 9 9 9 9 10 10 11 11 11 12 12 12 12 14 15

Current
Mean: 9.607 ms
Stdev: 1.175 ms (12.2%)
Runs: 8 8 8 8 8 8 9 9 9 9 9 9 9 10 10 10 10 10 10 10 10 10 11 11 11 11 12 12

@OSBotify OSBotify mentioned this pull request Dec 20, 2022
34 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @grgia in version: 1.2.42-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @yuwenmemon in version: 1.2.42-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@thesahindia

Copy link
Copy Markdown
Member

@puneetlath, @grgia can you please help with the C+ compensation ? #13637 is locked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants