Repository navigation
Update routes.yml - #13659
Update routes.yml#13659
Conversation
We forgot to add the article to the LHN navigation in [this PR](#13272). This should fix it.
|
@johncschuster can you check off the author checklist when you have a sec? I realize this doesn't affect the app so it's not necessary for review, but it IS necessary for the robots not to be mad at me when I merge haha |
marcochavezf
left a comment
There was a problem hiding this comment.
The change looks good, the Everything About Chat appears in the LHN:
Screen.Recording.2022-12-16.at.10.35.57.mov
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
Completed the checklists to merge this minor fix that we need for the site. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
|
🚀 Deployed to staging by @marcochavezf in version: 1.2.42-0 🚀
|
|
I will check this off from the list as this needs to be QAed in production |
|
🚀 Deployed to production by @yuwenmemon in version: 1.2.42-2 🚀
|
We forgot to add the
Everything-About-Chatarticle to the LHN navigation in this PR. This should fix it.Details
A couple weeks ago, Maddy and I were exploring how to move an article from one hub to another using just the GH interface. That worked great, but we (I) forgot that we needed to update the navigation in the LHN to match where the article was going.
Per the docs:
And under, Add the new page to routes.yml header:
Fixed Issues
$ There was no GH to move the article from one hub to another.
Tests
Already tested locally #13659 (review)
Offline tests
N/A
QA Steps
Everything About Chatarticle appears in the LHNEverything About Chatand verify the article is shown.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android