Repository navigation
[N7 Account Settings] Create personal details pages #14290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
63fd924
Set up routes for new personal details pages
Beamanator 35224f4
New initial personal details page
Beamanator ed029f5
Add legal name page
Beamanator 649d633
Fix personal details page init linking
Beamanator 2640c4c
Add date of birth page
Beamanator 894d60b
New Home Address page
Beamanator 0d0cdbe
Country picker initial commit
Beamanator e5211a0
Make variable names more clear
Beamanator 94d633d
Add button to navigate to personal details page
Beamanator 88b1b6f
Add all legal first name errors
Beamanator 3d0a9eb
Make variable names a bit clearer
Beamanator 084eae4
Add necessary default & trim
Beamanator b18abc5
Modify validation fn to be dynamic
Beamanator 78082ce
Start creating dob validation fn
Beamanator 3d4ee4a
Revert since we'll make a new function
Beamanator 942ff32
Make comment clearer
Beamanator 3eb5047
Remove unused imports
Beamanator f058f83
Add better date errors
Beamanator 5787f36
Move everything to new private_personalDetails key
Beamanator 2080f93
Finish up Address field validation
Beamanator dd5bf2d
Remove unused imports
Beamanator e2db532
Clean up required field validation
Beamanator efc6961
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator c77a752
Fix api endpoints, body data, and cleanup
Beamanator 45918a2
Clean up a lot
Beamanator 8f19829
Merge branch 'main' of github.com:Expensify/App into georgia-new-avatars
Beamanator 412fd1d
Allow google places to populate address field
Beamanator 5ba4976
Update translation key
Beamanator 974a83c
Add list of all countries for country picker
Beamanator ea79301
Address lint errors
Beamanator 0304ea2
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 8bd87cd
Language updates
Beamanator 080fbe8
Make dob vars match API
Beamanator b8742ab
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator b29fbcd
Make personal details routes reuse prefix
Beamanator db0a15e
Move United States name to const
Beamanator 9985601
Comment updates
Beamanator 326e883
Minor logic fix
Beamanator 3de46a3
Merge branch 'beaman-createPersonalDetailsPages' of github.com:Expens…
Beamanator 1cde4fb
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 2dd91d0
Lint fixes
Beamanator 6be2bc4
A few error updates
Beamanator c7a5c21
Combine common invalid date error message
Beamanator 956d419
Final bit of error message cleanup
Beamanator e1d06c7
Address lint errors
Beamanator 986a72a
Please don't make me strangle anyone
Beamanator 70dcd17
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 74405cf
Improve date validation errors
Beamanator cdd4ddc
Fix a few error messages
Beamanator f4bfe21
Add ability to cap address search at 50 characters
Beamanator ed38aa3
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 8862174
Use standard moment date format for all platforms
Beamanator 53e1b14
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 7e8a139
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator 1f61517
Add scrollview to page
Beamanator 8f3d0a9
(you saw nothing)
Beamanator bbf2e06
Fix country auto-population
Beamanator 1cdb126
Merge branch 'main' of github.com:Expensify/App into beaman-createPer…
Beamanator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to get spanish translation of all these 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I guess, we'll store only english value in storage.
Also, I would recommend adding a test to check that this list has equal number of entries in both english and Spanish translations and compare values at random indexes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm very true, I like those ideas - but also that got me thinking, we only show States in the StatePicker in English, right? Maybe a follow-up could be translating both of those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, these countries should be in spanish if selected. Do we display states, countries right now? I don't think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed 1:1 - We don't display countries yet, states so far we only display the state two letter code, which probably doesn't have a translation 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a follow-up for this since I don't want to hold this PR back much longer: #14549