Repository navigation
Move edit emoji picker button to bottom right - #15626
Conversation
|
@thesahindia @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@avijeetpandey just curious, why did you leave a review here? |
Reviewer Checklist
Screenshots/Videos |
thesahindia
left a comment
There was a problem hiding this comment.
Looks good to me as well!
cc: @marcaaron
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@marcaaron was just randomly going through the codebase, I am javascript dev, love reading code and seeing how people are doing it, nothing serious, please let me know if I can be of some help. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.2.79-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.79-0 🚀
|






Details
Moves the emoji picker button to the bottom right in the edit comment box
Fixed Issues
$ #15595
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android