Repository navigation
[NoQA] Remove unnecessary props in ArchivedReportFooter - #15687
Merged
Merged
Conversation
52 of 54 tasks
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
March 6, 2023 17:39
Contributor
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Julesssss
approved these changes
Mar 6, 2023
luacmartins
approved these changes
Mar 6, 2023
Contributor
Reviewer Checklist
Screenshots/Videos |
Contributor
|
I tested web & desktop only due to the likelihood of this only affecting one platform. (also Vit tested iOS) |
Contributor
18 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.2.80-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.80-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Details
In this PR, we had refactor part of the code and forgot to remove this reportClosedAction props, its is being pulled from Onyx now so no need to pass it down from the parent element.
Fixed Issues
Related to #15207
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
There is nothing really to test here since this props is pulled in the component from Onyx
Tested, web and ios
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android