Repository navigation
Fix overlay size - #26385
Fix overlay size#26385
Conversation
|
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
yo |
|
I can review! |
|
All yours @rushatgabhane! |
|
|
||
| overlayStyles: (current) => ({ | ||
| ...StyleSheet.absoluteFillObject, | ||
| position: 'fixed', |
There was a problem hiding this comment.
Does this work on iPad? If i'm not wrong, position type fixed doesn't work in react native.
There was a problem hiding this comment.
Yeah, but the overlay is visible only for wide view and that's something we don't support yet on iOS and Android.
There was a problem hiding this comment.
ios safari with ipad on landscape?
There was a problem hiding this comment.
could we think of some alternative solution that will work on landscape iPad?
I know that we don't support it yet, but I'd prefer to solve this problem for all platforms.
What do you think?
There was a problem hiding this comment.
By iOS and Android, I meant the native apps. It will work on safari/chrome mobile.
We could think about alternative solutions but supporting three pane view in native apps requires more changes anyway. I am not sure if it's worth doing now if the code can change.
There was a problem hiding this comment.
@rushatgabhane I think it does not work at all in native ipad now so we should not spend time on it now, but I agree that making it work in ipad landscape should be on our list soon
|
@adamgrzybowski can you also look into this tint issue #26405 in this pr? |
|
@mountiny is it ok with you if I remove my request for review? I don't really have context on this. |
|
@neil-marcellini absolutely fine |
So I used the I can change it, but I think it's worth checking the designs or something what the color really should be. @mountiny Let me know what you think! |
|
@adamgrzybowski @rushatgabhane can you please provide screenshots/ video in the PR and checklist @shawnborton could you please give this one a look and confirm the overlay looks good, once Adam will upload the video or you can run it locally too |
|
Sounds good, will wait for videos. |
|
Videos updated in the description |
|
Nice, that feels good to me! |
mountiny
left a comment
There was a problem hiding this comment.
@rushatgabhane All yours Shawn has approved, thanks!
I believe this is low risk PR but good design fix so we should not hold this one
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-05.at.12.48.53.movMobile Web - ChromeScreen.Recording.2023-09-05.at.13.10.36.movMobile Web - SafariScreen.Recording.2023-09-05.at.13.01.58.movDesktopScreen.Recording.2023-09-05.at.13.00.04.moviOSScreen.Recording.2023-09-05.at.12.55.58.movAndroidScreen.Recording.2023-09-05.at.13.07.13.mov |
|
@mountiny good to merge! |
|
@rushatgabhane Wojti has synced with main, any chance you could give this a quick retest before merging? thanks! |
|
sure, I can re-test once i reach home (3 hrs) |
|
amazing, thanks! |
|
@mountiny LGTM Screen.Recording.2023-09-12.at.20.03.09.mov |
|
Thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
|
|
||
| overlayStyles: (current) => ({ | ||
| ...StyleSheet.absoluteFillObject, | ||
| backgroundColor: themeColors.overlay, |
There was a problem hiding this comment.
This caused a regression #27353. The background color should have kept as overlay.
Details
I've changed the size of the overlay to offset the translate animation.
Fixed Issues
https://swmansion.slack.com/archives/C04878MDF34/p1693469210575919
$ #26390
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
androidWeb.mov
Mobile Web - Safari
iosWeb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov