Repository navigation
Fix - Distance Optimistic Data - follow up PR - #26618
Conversation
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I will be able to add videos after this is resolved. https://expensify.slack.com/archives/C049HHMV9SM/p1693771673626369 |
|
@allroundexperts I'll wait for your review before I review this PR |
|
Follow up PR was created for this comment: |
|
@allroundexperts please do a checklist 🙇 |
|
👋 @allroundexperts how's the checklist coming along? |
Hi. I did not get a chance to view it last night. Will finish it today. |
2 similar comments
Hi. I did not get a chance to view it last night. Will finish it today. |
Hi. I did not get a chance to view it last night. Will finish it today. |
|
Excellent! We're looking to deploy in the next couple of hours, so we can still make it on this one hopefully! |
|
@trjExpensify I think I won't be able to make it in 2 hours. I'll be able to review in about 4 hours. If this is urgent, please re-assign. |
Reviewer Checklist
Screenshots/VideosWeb26618web.mp4Mobile Web - Chrome26618chrome.mp4Mobile Web - Safari26618safari.mp4DesktopSame as web iOShaving some issues with the address look up being extra slow unrelated to this pr Android26618android.mp4 |
|
I hope to deploy in next hour so going to do the checklist |
|
@jeet-dhandha there are no recordings, how are they related to split bill you have referred here? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.64-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀
|
Details
Fixed Issues
$ #26518
PROPOSAL: #26518 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android