Repository navigation
[No QA] [TS migration] Migrate 'HapticFeedback' lib to TypeScript - #26774
srikarparsi merged 2 commits into
Conversation
|
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| type HapticFeedbackSuccess = () => void; | ||
| type HapticFeedbackError = () => void; | ||
|
|
||
| export type {HapticFeedbackPress, HapticFeedbackLongPress, HapticFeedbackSuccess, HapticFeedbackError}; |
There was a problem hiding this comment.
Same as this PR, what about defining a type for the whole file structure?
type HapticFeedback = {
press: () => void;
longPress: () => void;
success: () => void;
error: () => void;
};
const hapticFeedback: HapticFeedback = {
press: () => {},
longPress: () => {},
success: () => {},
error: () => {},
};
export default hapticFeedback;
fabioh8010
left a comment
There was a problem hiding this comment.
LGTM, CK still need to do the checklist.
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24801 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-12.at.00.31.38.movScreen.Recording.2023-09-12.at.00.31.50.movDesktopScreen.Recording.2023-09-12.at.00.32.04.movMobile Web - ChromeScreen.Recording.2023-09-12.at.00.32.45.movAndroidScreen.Recording.2023-09-12.at.00.34.02.movMobile Web - SafariScreen.Recording.2023-09-12.at.00.34.20.moviOSScreen.Recording.2023-09-12.at.00.34.36.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.69-2 🚀
|
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
Details
Migrate 'HapticFeedback' lib file to TypeScript
Fixed Issues
$ #24801
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-05.at.15.14.15.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Screen.Recording.2023-09-05.at.14.58.30.mov
Android
Screen.Recording.2023-09-05.at.14.57.43.mov