Repository navigation
Fix send button is enabled when composer contains only space #26851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aldo-expensify
merged 1 commit into
Expensify:main
from
bernhardoj:fix/26433-composer-send-button
Sep 25, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the solution a little bit because I found an issue with the onyx selector.
When the draft comment onyx is updated, the selector is triggered twice with different values.
First, the value will be boolean (wrong) and the second one will be the comment itself (correct).
The boolean value is based on what we return on the
selector. For example, if the comment is empty, the selector will be triggered withtrueand the comment value.As the above
isCommentEmptyprop is only used to initialize theisCommentEmptystate, I use a lazy init for the state which takes the draft comment withgetDraftComment. We did the same pattern here too:App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js
Line 107 in 1bdc5ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me 👍🏼