Repository navigation
[No QA] Use Node 20 for all JavaScript GitHub Actions - #31501
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Santhosh-Sellavel @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No C+ review needed here |
|
Going to add a bit more here |
|
Ok, ready for review |
| required: true | ||
| runs: | ||
| using: "node16" | ||
| using: "node20" |
There was a problem hiding this comment.
NAB but would be nice to standardize on ' or "
| using: "node20" | |
| using: 'node20' |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A - Deploy code only Android: mWeb ChromeN/A - Deploy code only iOS: NativeN/A - Deploy code only iOS: mWeb SafariN/A - Deploy code only MacOS: Chrome / SafariN/A - Deploy code only MacOS: DesktopN/A - Deploy code only |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀
|
Details
Update all our JavaScript GitHub Actions to use Node 20.
Fixed Issues
$ #25824
Tests
Tests are now running in Node 20, so all the actual JS actions are covered by tests running Node 20 and should pass. No manual testing really.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop