Repository navigation
Fix chat infinite loading when opening a chat with report id of 0 - #33394
Conversation
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| // Report ID will be empty when the reports collection is empty. | ||
| // This could happen when we are loading the collection for the first time after logging in. | ||
| if (!ReportUtils.isValidReportIDFromPath(reportIDFromPath)) { | ||
| if (!reportIDFromPath) { |
There was a problem hiding this comment.
@alitoshmatov Based on @neil-marcellini comment, we want to use the main solution
|
Here is a video showing it works fine for other invalid report ids Screen.Recording.2023-12-21.at.13.50.57.movHere is a video showing it works fine after logging in (the report id is empty) Screen.Recording.2023-12-21.at.14.16.08.mov |
|
Waiting for feedback here #32651 (comment) |
|
Waiting for a confirmation - #32651 (comment) |
|
@alitoshmatov code updated |
Reviewer Checklist
Screenshots/VideosAndroid: Nativen/aAndroid: mWeb Chromeinvalid-report-mweb.moviOS: Nativen/aiOS: mWeb Safariinvalid-report-safari.mp4MacOS: Chrome / Safariinvalid-report-web.movMacOS: Desktopinvalid-report-desktop.mov |
|
@bernhardoj please fix the typescript checks, maybe by merging main, and rename the variable while you're at it. |
|
@neil-marcellini merged with main |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀
|
Details
If the report id is 0 or "null", we don't send an API request and the loading local state is always true, so the skeleton loader is showing infinitely.
Fixed Issues
$ #32651
PROPOSAL: #32651 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2023-12-21.at.13.58.39.mov
Android: mWeb Chrome
Screen.Recording.2023-12-21.at.13.54.14.mov
iOS: Native
Screen.Recording.2023-12-21.at.14.13.21.mov
iOS: mWeb Safari
Screen.Recording.2023-12-21.at.14.14.18.mov
MacOS: Chrome / Safari
Screen.Recording.2023-12-21.at.13.50.25.mov
MacOS: Desktop
Screen.Recording.2023-12-21.at.13.52.04.mov