Repository navigation
refactor: move methods to personalDetailsUtils, remove unused one - #34657
puneetlath merged 12 commits into
Conversation
|
@situchan friendly bump 🙂 |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
| * | ||
| * @param login - user's login | ||
| * @param passedPersonalDetails - details object with firstName and lastName | ||
| * @returns - The effective display name |
There was a problem hiding this comment.
This is not needed in TS if params are self-explanatory
| * | |
| * @param login - user's login | |
| * @param passedPersonalDetails - details object with firstName and lastName | |
| * @returns - The effective display name |
There was a problem hiding this comment.
@situchan but other methods in this file also have params listed
There was a problem hiding this comment.
There was a problem hiding this comment.
@situchan should I remove the params from other methods' docs as well? wdyt?
There was a problem hiding this comment.
Let’s remove it from this method though, yeah?
| * | ||
| * @param login - user's login | ||
| * @param displayName - user display name | ||
| * @param firstName | ||
| * @param lastName |
There was a problem hiding this comment.
Same here
| * | |
| * @param login - user's login | |
| * @param displayName - user display name | |
| * @param firstName | |
| * @param lastName |
- 2. Go to Settings -> Personal Details -> change your display name - verify that it works correctly.
+ 2. Go to Settings -> Profile -> Display name > change your display name - verify that it works correctly. |
puneetlath
left a comment
There was a problem hiding this comment.
Looks good to me other than the things that @situchan already pointed out.
|
@situchan @puneetlath done! |
|
@koko57 looks like the performance tests are failing. |
|
@puneetlath fixed! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|

Details
Fixed Issues
$ #31312
PROPOSAL: #31312 (comment)
Tests
Offline tests
n/a
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop