Repository navigation
Android-Attachments-App crashes on uploading specific PDF - #35222
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-01-29.at.15.47.02.mp4Android: mWeb ChromeCleanShot.2024-01-29.at.15.55.13.mp4iOS: NativeCleanShot.2024-02-05.at.13.46.01.mp4iOS: mWeb SafariCleanShot.2024-02-05.at.13.47.01.mp4MacOS: Chrome / SafariCleanShot.2024-02-05.at.12.59.19.mp4MacOS: DesktopCleanShot.2024-02-05.at.13.27.34.mp4 |
|
@pradeepmdk Could you please merge main? The App is crashing on IOS and web
|
|
@pradeepmdk Could you please merge main again? this looks scary 🥲
|
|
Sure |
|
@pradeepmdk friendly bump. |
2e75403 to
8a37b8e
Compare
mountiny
left a comment
There was a problem hiding this comment.
Thanks! @pradeepmdk where can we tack if the upstream will be fixed?
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
our upstream PR is already merged. due to this PR wonday/react-native-pdf#792 we could not use the latest version. |
|
Yep I mean fix for this bug addressed in this patch |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀
|


Details
Fixed Issues
$ #29743
PROPOSAL: #29743 (comment)
Tests
class-9-maths-chapter-10-solutions.pdf
Offline tests
Same as test
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
out.mp4
Android: mWeb Chrome
output.mov
iOS: Native
output.mp4
iOS: mWeb Safari
output.mp4
MacOS: Chrome / Safari
output.mp4
MacOS: Desktop
ouptut.mp4