Repository navigation
remove unnecessary concierge check - #35439
Conversation
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@srikarparsi review checklist shouldn't be necessary here |
|
Alright it took a long time but this is ready now. On second thought I'm going to take this through the whole C+ review flow just to be safe. |
|
@eVoloshchak I added you as a C+ reviewer for this since you were assigned to the original issue. The issue was fixed internally but the internal change means this code should no longer be needed. Can you double check that getting rid of this code doesn't cause any regressions? 🙂 |
eVoloshchak
left a comment
There was a problem hiding this comment.
Works well, I'll try to think of steps for the QA team so they could test this
The same check exists in src/pages/DetailsPage.tsx, we could also remove it
Line 67 in 3126658
|
Typecheck failure appears unrelated to my changes, looks like it is happening on main |
Beamanator
left a comment
There was a problem hiding this comment.
I like 👍
Good question about QA team - we could just make this internal QA pretty easily
Also I'm 99% sure the lint issue is fixed already, just gotta pull main
|
Also @blimpich do we want @eVoloshchak to do a full review or no? |
|
Yeah lets do a full review to be safe 🙂 |
Reviewer Checklist
Screenshots/Videos |
eVoloshchak
left a comment
There was a problem hiding this comment.
Tests well!
Good question about QA team - we could just make this internal QA pretty easily
@Beamanator, let's do that, I don't think QA would be able to test this
|
@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #37190. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|






Details
https://github.com/Expensify/Auth/pull/9776 makes this chunk of code unnecessary.
Fixed Issues
$ related to #32581
cc: @Beamanator
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop